Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [RFC] Update description of parse_breakpoint_sals
Date: Fri, 04 Feb 2011 17:33:00 -0000	[thread overview]
Message-ID: <1296840760.3204.4.camel@hactar> (raw)

Hi,

The comment describing parse_breakpoint_sals is outdated. This patch
updates it and expands it a bit. I was tempted to just commit it as
obvious, but people more familiar with the function may have something
to add or comment to my new description...
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2011-02-04  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (parse_breakpoint_sals): Fix description.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 656dedd..39d9b02 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7485,10 +7485,13 @@ create_breakpoints_sal (struct gdbarch *gdbarch,
     }
 }
 
-/* Parse ARG which is assumed to be a SAL specification possibly
+/* Parse ADDRESS which is assumed to be a SAL specification possibly
    followed by conditionals.  On return, SALS contains an array of SAL
    addresses found.  ADDR_STRING contains a vector of (canonical)
-   address strings.  ARG points to the end of the SAL.  */
+   address strings.  ADDRESS points to the end of the SAL.
+
+   The array and the line spec strings are allocated on the heap, it is
+   the caller's responsibility to free them.  */
 
 static void
 parse_breakpoint_sals (char **address,



             reply	other threads:[~2011-02-04 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 17:33 Thiago Jung Bauermann [this message]
2011-02-06  7:23 ` Joel Brobecker
2011-02-07 13:40   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296840760.3204.4.camel@hactar \
    --to=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox