From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31626 invoked by alias); 4 Feb 2011 17:33:50 -0000 Received: (qmail 31615 invoked by uid 22791); 4 Feb 2011 17:33:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Feb 2011 17:33:45 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with XMail ESMTP for from ; Fri, 4 Feb 2011 15:33:42 -0200 Received: from mailhub3.br.ibm.com ([9.18.232.110]) by e24smtp04.br.ibm.com ([10.172.0.140]) with XMail ESMTP; Fri, 4 Feb 2011 15:33:39 -0200 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p14HfaK21597640 for ; Fri, 4 Feb 2011 15:41:37 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p14HXIvj008743 for ; Fri, 4 Feb 2011 15:33:18 -0200 Received: from [9.8.0.49] ([9.8.0.49]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p14HXIdg006873 for ; Fri, 4 Feb 2011 15:33:18 -0200 Subject: [RFC] Update description of parse_breakpoint_sals From: Thiago Jung Bauermann To: gdb-patches ml Content-Type: text/plain; charset="UTF-8" Date: Fri, 04 Feb 2011 17:33:00 -0000 Message-ID: <1296840760.3204.4.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11020417-8936-0000-0000-000000662B17 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00080.txt.bz2 Hi, The comment describing parse_breakpoint_sals is outdated. This patch updates it and expands it a bit. I was tempted to just commit it as obvious, but people more familiar with the function may have something to add or comment to my new description... -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2011-02-04 Thiago Jung Bauermann * breakpoint.c (parse_breakpoint_sals): Fix description. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 656dedd..39d9b02 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -7485,10 +7485,13 @@ create_breakpoints_sal (struct gdbarch *gdbarch, } } -/* Parse ARG which is assumed to be a SAL specification possibly +/* Parse ADDRESS which is assumed to be a SAL specification possibly followed by conditionals. On return, SALS contains an array of SAL addresses found. ADDR_STRING contains a vector of (canonical) - address strings. ARG points to the end of the SAL. */ + address strings. ADDRESS points to the end of the SAL. + + The array and the line spec strings are allocated on the heap, it is + the caller's responsibility to free them. */ static void parse_breakpoint_sals (char **address,