[rfa] Fix comment in can_use_hardware_watchpoint

[rfa] Fix comment in can_use_hardware_watchpoint

[Thiago Jung Bauermann]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi,

Ulrich Weigand elucidated a question asked in a comment in
can_use_hardware_watchpoint. This patch fixes it.

Thanks and regards,
Thiago Jung Bauermann
IBM Linux Technology Center


2010-07-01  Ulrich Weigand  <uweigand@de.ibm.com>
	    Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (can_use_hardware_watchpoint): Answer "what does this
	represent?" question in comment.  Change comment to a proper sentence.


[-- Attachment #2: comment.diff --]
[-- Type: text/x-patch, Size: 734 bytes --]

Index: gdb/breakpoint.c
===================================================================
--- gdb.orig/breakpoint.c	2010-06-30 23:24:53.000000000 -0300
+++ gdb/breakpoint.c	2010-06-30 23:25:02.000000000 -0300
@@ -8147,9 +8147,9 @@ can_use_hardware_watchpoint (struct valu
 	}
       else if (VALUE_LVAL (v) != not_lval
 	       && deprecated_value_modifiable (v) == 0)
-	return 0;	/* ??? What does this represent? */
+	return 0;	/* These are values from the history (e.g., $1).  */
       else if (VALUE_LVAL (v) == lval_register)
-	return 0;	/* cannot watch a register with a HW watchpoint */
+	return 0;	/* Cannot watch a register with a HW watchpoint.  */
     }
 
   /* The expression itself looks suitable for using a hardware

Re: [rfa] Fix comment in can_use_hardware_watchpoint

[Ulrich Weigand]

Thiago Jung Bauermann wrote:

> 2010-07-01  Ulrich Weigand  <uweigand@de.ibm.com>
> 	    Thiago Jung Bauermann  <bauerman@br.ibm.com>
> 
> 	* breakpoint.c (can_use_hardware_watchpoint): Answer "what does this
> 	represent?" question in comment.  Change comment to a proper sentence.

This is OK, thanks.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [rfa] Fix comment in can_use_hardware_watchpoint

[Thiago Jung Bauermann]

On Fri, 2010-07-02 at 15:21 +0200, Ulrich Weigand wrote:
> Thiago Jung Bauermann wrote:
> 
> > 2010-07-01  Ulrich Weigand  <uweigand@de.ibm.com>
> > 	    Thiago Jung Bauermann  <bauerman@br.ibm.com>
> > 
> > 	* breakpoint.c (can_use_hardware_watchpoint): Answer "what does this
> > 	represent?" question in comment.  Change comment to a proper sentence.
> 
> This is OK, thanks.

Thanks, committed.