From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31269 invoked by alias); 1 Jul 2010 19:54:19 -0000 Received: (qmail 31259 invoked by uid 22791); 1 Jul 2010 19:54:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp02.br.ibm.com (HELO e24smtp02.br.ibm.com) (32.104.18.86) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 19:54:14 +0000 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp02.br.ibm.com (8.14.4/8.13.1) with ESMTP id o61JtX3e029939 for ; Thu, 1 Jul 2010 16:55:33 -0300 Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o61Jwmrs917870 for ; Thu, 1 Jul 2010 16:58:49 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o61Js5Gj030248 for ; Thu, 1 Jul 2010 16:54:05 -0300 Received: from [9.8.4.195] ([9.8.4.195]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id o61Js5VR030189 for ; Thu, 1 Jul 2010 16:54:05 -0300 Subject: [rfa] Fix comment in can_use_hardware_watchpoint From: Thiago Jung Bauermann To: gdb-patches ml Content-Type: multipart/mixed; boundary="=-IOcqHbQaebUzpEDKidgB" Date: Thu, 01 Jul 2010 19:54:00 -0000 Message-ID: <1278014039.4087.305.camel@hactar.cps.virtua.com.br> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00030.txt.bz2 --=-IOcqHbQaebUzpEDKidgB Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-length: 431 Hi, Ulrich Weigand elucidated a question asked in a comment in can_use_hardware_watchpoint. This patch fixes it. Thanks and regards, Thiago Jung Bauermann IBM Linux Technology Center 2010-07-01 Ulrich Weigand Thiago Jung Bauermann * breakpoint.c (can_use_hardware_watchpoint): Answer "what does this represent?" question in comment. Change comment to a proper sentence. --=-IOcqHbQaebUzpEDKidgB Content-Disposition: attachment; filename="comment.diff" Content-Type: text/x-patch; name="comment.diff"; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-length: 734 Index: gdb/breakpoint.c =================================================================== --- gdb.orig/breakpoint.c 2010-06-30 23:24:53.000000000 -0300 +++ gdb/breakpoint.c 2010-06-30 23:25:02.000000000 -0300 @@ -8147,9 +8147,9 @@ can_use_hardware_watchpoint (struct valu } else if (VALUE_LVAL (v) != not_lval && deprecated_value_modifiable (v) == 0) - return 0; /* ??? What does this represent? */ + return 0; /* These are values from the history (e.g., $1). */ else if (VALUE_LVAL (v) == lval_register) - return 0; /* cannot watch a register with a HW watchpoint */ + return 0; /* Cannot watch a register with a HW watchpoint. */ } /* The expression itself looks suitable for using a hardware --=-IOcqHbQaebUzpEDKidgB--