Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Subject: [rfa] Fix comment in can_use_hardware_watchpoint
Date: Thu, 01 Jul 2010 19:54:00 -0000	[thread overview]
Message-ID: <1278014039.4087.305.camel@hactar.cps.virtua.com.br> (raw)

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi,

Ulrich Weigand elucidated a question asked in a comment in
can_use_hardware_watchpoint. This patch fixes it.

Thanks and regards,
Thiago Jung Bauermann
IBM Linux Technology Center


2010-07-01  Ulrich Weigand  <uweigand@de.ibm.com>
	    Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (can_use_hardware_watchpoint): Answer "what does this
	represent?" question in comment.  Change comment to a proper sentence.


[-- Attachment #2: comment.diff --]
[-- Type: text/x-patch, Size: 734 bytes --]

Index: gdb/breakpoint.c
===================================================================
--- gdb.orig/breakpoint.c	2010-06-30 23:24:53.000000000 -0300
+++ gdb/breakpoint.c	2010-06-30 23:25:02.000000000 -0300
@@ -8147,9 +8147,9 @@ can_use_hardware_watchpoint (struct valu
 	}
       else if (VALUE_LVAL (v) != not_lval
 	       && deprecated_value_modifiable (v) == 0)
-	return 0;	/* ??? What does this represent? */
+	return 0;	/* These are values from the history (e.g., $1).  */
       else if (VALUE_LVAL (v) == lval_register)
-	return 0;	/* cannot watch a register with a HW watchpoint */
+	return 0;	/* Cannot watch a register with a HW watchpoint.  */
     }
 
   /* The expression itself looks suitable for using a hardware

             reply	other threads:[~2010-07-01 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 19:54 Thiago Jung Bauermann [this message]
2010-07-02 13:21 ` Ulrich Weigand
2010-07-02 19:55   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278014039.4087.305.camel@hactar.cps.virtua.com.br \
    --to=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox