Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Build error in 2009-06-30 patch, with fix
@ 2009-07-05 19:15 Danny Backx
  2009-07-05 19:31 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: Danny Backx @ 2009-07-05 19:15 UTC (permalink / raw)
  To: gdb-patches

The 2009-06-30 patch that adds i386-low.c doesn't appear to have added
this file to the configure.srv for i*86-*-mingw32ce* .

The patch below fixes this.

	Danny



pavilion: {753} cvs diff configure.srv
Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.42
diff -u -r1.42 configure.srv
--- configure.srv       30 Jun 2009 16:35:25 -0000      1.42
+++ configure.srv       5 Jul 2009 19:13:09 -0000
@@ -63,7 +63,7 @@
                        ;;
   i[34567]86-*-mingw32ce*)
                        srv_regobj=reg-i386.o
-                       srv_tgtobj="win32-low.o win32-i386-low.o"
+                       srv_tgtobj="win32-low.o win32-i386-low.o
i386-low.o"
                        srv_tgtobj="${srv_tgtobj} wincecompat.o"
                        # hostio_last_error implementation is in
win32-low.c
                        srv_hostio_err_objs=""


-- 
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Build error in 2009-06-30 patch, with fix
  2009-07-05 19:15 Build error in 2009-06-30 patch, with fix Danny Backx
@ 2009-07-05 19:31 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2009-07-05 19:31 UTC (permalink / raw)
  To: gdb-patches, danny.backx

On Sunday 05 July 2009 20:15:46, Danny Backx wrote:
> The 2009-06-30 patch that adds i386-low.c doesn't appear to have added
> this file to the configure.srv for i*86-*-mingw32ce* .
> 
> The patch below fixes this.
> 

Thanks.

Please always post a ChangeLog entry.  If you don't write one,
someone else gets to write it.

>    i[34567]86-*-mingw32ce*)
>                         srv_regobj=reg-i386.o
> -                       srv_tgtobj="win32-low.o win32-i386-low.o"
> +                       srv_tgtobj="win32-low.o win32-i386-low.o
> i386-low.o"

Prepending i386-low.o instead of appending keeps this list in 100% sync
with srv_tgtobj in the i[34567]86-*-mingw* and i[34567]86-*-cygwin*
configurations.

I've applied the patch below.

-- 
Pedro Alves

2009-07-04  Danny Backx  <dannybackx@users.sourceforge.net>

	* configure.srv (i[34567]86-*-mingw32ce*): Add i386-low.o to
	srv_tgtobj.

---
 gdb/gdbserver/configure.srv |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/configure.srv
===================================================================
--- src.orig/gdb/gdbserver/configure.srv	2009-07-05 20:21:22.000000000 +0100
+++ src/gdb/gdbserver/configure.srv	2009-07-05 20:22:33.000000000 +0100
@@ -63,7 +63,7 @@ case "${target}" in
 			;;
   i[34567]86-*-mingw32ce*)
 			srv_regobj=reg-i386.o
-			srv_tgtobj="win32-low.o win32-i386-low.o"
+			srv_tgtobj="i386-low.o win32-low.o win32-i386-low.o"
 			srv_tgtobj="${srv_tgtobj} wincecompat.o"
 			# hostio_last_error implementation is in win32-low.c
 			srv_hostio_err_objs=""
-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-05 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-05 19:15 Build error in 2009-06-30 patch, with fix Danny Backx
2009-07-05 19:31 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox