Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org,  danny.backx@scarlet.be
Subject: Re: Build error in 2009-06-30 patch, with fix
Date: Sun, 05 Jul 2009 19:31:00 -0000	[thread overview]
Message-ID: <200907052032.21574.pedro@codesourcery.com> (raw)
In-Reply-To: <1246821346.10857.3.camel@pavilion>

On Sunday 05 July 2009 20:15:46, Danny Backx wrote:
> The 2009-06-30 patch that adds i386-low.c doesn't appear to have added
> this file to the configure.srv for i*86-*-mingw32ce* .
> 
> The patch below fixes this.
> 

Thanks.

Please always post a ChangeLog entry.  If you don't write one,
someone else gets to write it.

>    i[34567]86-*-mingw32ce*)
>                         srv_regobj=reg-i386.o
> -                       srv_tgtobj="win32-low.o win32-i386-low.o"
> +                       srv_tgtobj="win32-low.o win32-i386-low.o
> i386-low.o"

Prepending i386-low.o instead of appending keeps this list in 100% sync
with srv_tgtobj in the i[34567]86-*-mingw* and i[34567]86-*-cygwin*
configurations.

I've applied the patch below.

-- 
Pedro Alves

2009-07-04  Danny Backx  <dannybackx@users.sourceforge.net>

	* configure.srv (i[34567]86-*-mingw32ce*): Add i386-low.o to
	srv_tgtobj.

---
 gdb/gdbserver/configure.srv |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/configure.srv
===================================================================
--- src.orig/gdb/gdbserver/configure.srv	2009-07-05 20:21:22.000000000 +0100
+++ src/gdb/gdbserver/configure.srv	2009-07-05 20:22:33.000000000 +0100
@@ -63,7 +63,7 @@ case "${target}" in
 			;;
   i[34567]86-*-mingw32ce*)
 			srv_regobj=reg-i386.o
-			srv_tgtobj="win32-low.o win32-i386-low.o"
+			srv_tgtobj="i386-low.o win32-low.o win32-i386-low.o"
 			srv_tgtobj="${srv_tgtobj} wincecompat.o"
 			# hostio_last_error implementation is in win32-low.c
 			srv_hostio_err_objs=""
-- 
Pedro Alves


      reply	other threads:[~2009-07-05 19:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-05 19:15 Danny Backx
2009-07-05 19:31 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907052032.21574.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=danny.backx@scarlet.be \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox