From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2991 invoked by alias); 5 Jul 2009 19:31:53 -0000 Received: (qmail 2979 invoked by uid 22791); 5 Jul 2009 19:31:50 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_93,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jul 2009 19:31:41 +0000 Received: (qmail 31557 invoked from network); 5 Jul 2009 19:31:39 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Jul 2009 19:31:39 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, danny.backx@scarlet.be Subject: Re: Build error in 2009-06-30 patch, with fix Date: Sun, 05 Jul 2009 19:31:00 -0000 User-Agent: KMail/1.9.10 References: <1246821346.10857.3.camel@pavilion> In-Reply-To: <1246821346.10857.3.camel@pavilion> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907052032.21574.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00114.txt.bz2 On Sunday 05 July 2009 20:15:46, Danny Backx wrote: > The 2009-06-30 patch that adds i386-low.c doesn't appear to have added > this file to the configure.srv for i*86-*-mingw32ce* . > > The patch below fixes this. > Thanks. Please always post a ChangeLog entry. If you don't write one, someone else gets to write it. > i[34567]86-*-mingw32ce*) > srv_regobj=reg-i386.o > - srv_tgtobj="win32-low.o win32-i386-low.o" > + srv_tgtobj="win32-low.o win32-i386-low.o > i386-low.o" Prepending i386-low.o instead of appending keeps this list in 100% sync with srv_tgtobj in the i[34567]86-*-mingw* and i[34567]86-*-cygwin* configurations. I've applied the patch below. -- Pedro Alves 2009-07-04 Danny Backx * configure.srv (i[34567]86-*-mingw32ce*): Add i386-low.o to srv_tgtobj. --- gdb/gdbserver/configure.srv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/gdbserver/configure.srv =================================================================== --- src.orig/gdb/gdbserver/configure.srv 2009-07-05 20:21:22.000000000 +0100 +++ src/gdb/gdbserver/configure.srv 2009-07-05 20:22:33.000000000 +0100 @@ -63,7 +63,7 @@ case "${target}" in ;; i[34567]86-*-mingw32ce*) srv_regobj=reg-i386.o - srv_tgtobj="win32-low.o win32-i386-low.o" + srv_tgtobj="i386-low.o win32-low.o win32-i386-low.o" srv_tgtobj="${srv_tgtobj} wincecompat.o" # hostio_last_error implementation is in win32-low.c srv_hostio_err_objs="" -- Pedro Alves