From: Vinay Sridhar <vinay@linux.vnet.ibm.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Daniel Jacobowitz <drow@false.org>,
luisgpm@linux.vnet.ibm.com
Subject: Re: [RFC][Patch] Fix gdb failure to access tls data for parent thread
Date: Wed, 25 Feb 2009 18:28:00 -0000 [thread overview]
Message-ID: <1235546174.13712.6.camel@localhost.localdomain> (raw)
In-Reply-To: <200902241716.09368.pedro@codesourcery.com>
On Tue, 2009-02-24 at 17:16 +0000, Pedro Alves wrote:
> On Tuesday 24 February 2009 15:58:31, Pedro Alves wrote:
> > On Tuesday 24 February 2009 15:31:53, Daniel Jacobowitz wrote:
> > > 81 /* Verify that this thread's pid field matches the child PID.
> > > 82 If its pid field is negative, it's about to do a fork or it
> > > 83 is the sole thread in a fork child. */
> >
> > Boo, I'm on glibc 2.7, which doesn't have this check, but I see it
> > in glibc-2.9 sources...
> >
> > > It's checking that the PID (not TID) matches proc_handle.pid. We need
> > > to find another way to read from a stopped thread, since if we put any
> > > other PID there, we get no threads. I would suggest expanding
> > > ps_prochandle to include a memory thread as ptid_t.
> >
> > Right, I'll take this.
>
> Here it is, how does it look? This works on glibc-2.7, but then again, that
> version isn't affected by this. Could one of you please give it a shot and
> see if it fixes the reported issue?
>
Tested this with the Feb snapshot. The patch fixes the issue. I'm using
glibc-2.9..
Thanks,
Vinay
next prev parent reply other threads:[~2009-02-25 7:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 8:47 Vinay Sridhar
2009-02-04 13:29 ` Daniel Jacobowitz
2009-02-11 8:33 ` Vinay Sridhar
2009-02-11 15:53 ` Daniel Jacobowitz
2009-02-12 5:45 ` Vinay Sridhar
2009-02-16 3:19 ` Daniel Jacobowitz
2009-02-16 15:04 ` Vinay Sridhar
2009-02-16 15:20 ` Daniel Jacobowitz
2009-02-17 7:01 ` Vinay Sridhar
2009-02-17 16:20 ` Daniel Jacobowitz
2009-02-20 8:31 ` Vinay Sridhar
2009-02-23 0:17 ` Daniel Jacobowitz
2009-02-23 9:20 ` Vinay Sridhar
2009-02-23 16:10 ` Daniel Jacobowitz
2009-02-24 7:11 ` Pedro Alves
2009-02-24 13:33 ` Vinay Sridhar
2009-02-24 13:39 ` Vinay Sridhar
2009-02-24 17:16 ` Daniel Jacobowitz
2009-02-24 18:52 ` Pedro Alves
2009-02-24 18:58 ` Pedro Alves
2009-02-25 18:28 ` Vinay Sridhar [this message]
2009-02-27 21:49 ` Pedro Alves
2009-02-24 10:57 ` Vinay Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235546174.13712.6.camel@localhost.localdomain \
--to=vinay@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox