How to submit a LARGE patch

How to submit a LARGE patch

[Jeremy Bennett]

How do I submit a LARGE patch to this group.

I've made some suggested changes to the GDB Internals manual, but since
the change includes an image, the diff file is nearly 300k, when gzipped
and uuencoded. I tried posting it yesterday, but since it hasn't
appeared, I presume there is a size limit.

It's not a particularly large image, but Texinfo requires lots of
flavours (EPS, PDF, PNG, TXT as well as the SVG source it all came
from), so the file gets big.

Second question. When I create the diff file from the patch, is that
expected to be relative to the main source tree, or just the directory
containing the changes (in this case the gdb/doc directory).

Advice appreciated.

Thanks,


Jeremy

-- 
Tel:      +44 (1202) 416955
Cell:     +44 (7970) 676050
SkypeID: jeremybennett
Email:   jeremy.bennett@embecosm.com
Web:     www.embecosm.com

Re: How to submit a LARGE patch

[Eli Zaretskii]

> From: Jeremy Bennett <jeremy.bennett@embecosm.com>
> Date: Sat, 20 Sep 2008 12:22:25 +0100
> 
> How do I submit a LARGE patch to this group.

My own preference is to submit is as text, not as binary attachment.
Unless your mailer does all kinds of dirty tricks with text, such as
folding long lines etc., this makes reviewing the patch by far the
easiest.

> I've made some suggested changes to the GDB Internals manual, but since
> the change includes an image, the diff file is nearly 300k, when gzipped
> and uuencoded.

How large it is before gzip?

> Second question. When I create the diff file from the patch, is that
> expected to be relative to the main source tree, or just the directory
> containing the changes (in this case the gdb/doc directory).

It doesn't matter, at least not to me.  The information about the
directory is included in the diffs, so applying them correctly is
easy.

Re: How to submit a LARGE patch

[Jeremy Bennett]

On Sat, 2008-09-20 at 14:35 +0300, Eli Zaretskii wrote:

> My own preference is to submit is as text, not as binary attachment.
> Unless your mailer does all kinds of dirty tricks with text, such as
> folding long lines etc., this makes reviewing the patch by far the
> easiest.

Thanks for the quick reply.

I'm happy to submit as plain text, but the PNG & PDF versions of the
image have to be binary (or uuencoded binary).

> 
> > I've made some suggested changes to the GDB Internals manual, but since
> > the change includes an image, the diff file is nearly 300k, when gzipped
> > and uuencoded.
> 
> How large it is before gzip?

500k. That's broken down as:
 82k - changes to gdbint.texinfo source
 48k - original image (SVG)
  1k - text version of image (for info)
 67k - PNG version of image (binary, for HTML)
 78k - PDF version of image (binary, for PDF)
218k - EPS version of image (for DVI)
 
gzip reduces it to 200k, uuencoding (as suggested in the CONTRIBUTE
file) inflates it back to 300k.

I can break down the patch into just the Texinfo change and then each
image separately. Your further suggestions on this would be welcome.

Thanks,


Jeremy
-- 
Tel:      +44 (1202) 416955
Cell:     +44 (7970) 676050
SkypeID: jeremybennett
Email:   jeremy.bennett@embecosm.com
Web:     www.embecosm.com

Re: How to submit a LARGE patch

[Eli Zaretskii]

> From: Jeremy Bennett <jeremy.bennett@embecosm.com>
> Date: Sat, 20 Sep 2008 13:15:49 +0100
> 
> I'm happy to submit as plain text, but the PNG & PDF versions of the
> image have to be binary (or uuencoded binary).

That'd be fine with me, except I think there are some limits imposed
by whatever handles the mailing list.  Someone else will probably
respond with the info about that.  (Personally, I don't think 500KB is
large enough to bother, but that's me.)

> I can break down the patch into just the Texinfo change and then each
> image separately.

That'd be the most useful way.  Please do.

Thanks.