Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jeremy Bennett <jeremy.bennett@embecosm.com>
To: gdb-patches@sourceware.org
Subject: Re: How to submit a LARGE patch
Date: Sat, 20 Sep 2008 12:16:00 -0000	[thread overview]
Message-ID: <1221912949.2827.469.camel@thomas> (raw)
In-Reply-To: <ur67foxs8.fsf@gnu.org>

On Sat, 2008-09-20 at 14:35 +0300, Eli Zaretskii wrote:

> My own preference is to submit is as text, not as binary attachment.
> Unless your mailer does all kinds of dirty tricks with text, such as
> folding long lines etc., this makes reviewing the patch by far the
> easiest.

Thanks for the quick reply.

I'm happy to submit as plain text, but the PNG & PDF versions of the
image have to be binary (or uuencoded binary).

> 
> > I've made some suggested changes to the GDB Internals manual, but since
> > the change includes an image, the diff file is nearly 300k, when gzipped
> > and uuencoded.
> 
> How large it is before gzip?

500k. That's broken down as:
 82k - changes to gdbint.texinfo source
 48k - original image (SVG)
  1k - text version of image (for info)
 67k - PNG version of image (binary, for HTML)
 78k - PDF version of image (binary, for PDF)
218k - EPS version of image (for DVI)
 
gzip reduces it to 200k, uuencoding (as suggested in the CONTRIBUTE
file) inflates it back to 300k.

I can break down the patch into just the Texinfo change and then each
image separately. Your further suggestions on this would be welcome.

Thanks,


Jeremy
-- 
Tel:      +44 (1202) 416955
Cell:     +44 (7970) 676050
SkypeID: jeremybennett
Email:   jeremy.bennett@embecosm.com
Web:     www.embecosm.com



  reply	other threads:[~2008-09-20 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20 11:23 Jeremy Bennett
2008-09-20 11:36 ` Eli Zaretskii
2008-09-20 12:16   ` Jeremy Bennett [this message]
2008-09-20 13:22     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221912949.2827.469.camel@thomas \
    --to=jeremy.bennett@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox