From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7420 invoked by alias); 20 Sep 2008 11:36:17 -0000 Received: (qmail 7410 invoked by uid 22791); 20 Sep 2008 11:36:17 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout3.012.net.il (HELO mtaout3.012.net.il) (84.95.2.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 20 Sep 2008 11:35:35 +0000 Received: from HOME-C4E4A596F7 ([77.127.116.246]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K7H00DB8S8IP5C1@i_mtaout3.012.net.il> for gdb-patches@sourceware.org; Sat, 20 Sep 2008 14:36:30 +0300 (IDT) Date: Sat, 20 Sep 2008 11:36:00 -0000 From: Eli Zaretskii Subject: Re: How to submit a LARGE patch In-reply-to: <1221909745.2827.456.camel@thomas> X-012-Sender: halo1@inter.net.il To: jeremy.bennett@embecosm.com Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: References: <1221909745.2827.456.camel@thomas> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00432.txt.bz2 > From: Jeremy Bennett > Date: Sat, 20 Sep 2008 12:22:25 +0100 > > How do I submit a LARGE patch to this group. My own preference is to submit is as text, not as binary attachment. Unless your mailer does all kinds of dirty tricks with text, such as folding long lines etc., this makes reviewing the patch by far the easiest. > I've made some suggested changes to the GDB Internals manual, but since > the change includes an image, the diff file is nearly 300k, when gzipped > and uuencoded. How large it is before gzip? > Second question. When I create the diff file from the patch, is that > expected to be relative to the main source tree, or just the directory > containing the changes (in this case the gdb/doc directory). It doesn't matter, at least not to me. The information about the directory is included in the diffs, so applying them correctly is easy.