[commit] remove extra verbose -log calls in testcases

[commit] remove extra verbose -log calls in testcases

[Thiago Jung Bauermann]

As noticed by Joel in my FPSCR testcase, it's not usual to call verbose
twice. Committed the following.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2008-09-05  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* gdb.arch/altivec-abi.exp: Remove extra verbose call.
	* gdb.arch/altivec-regs.exp: Likewise.
	* gdb.arch/vsx-regs.exp: Likewise.

diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp
index 2d84013..358edb9 100644
--- a/gdb/testsuite/gdb.arch/altivec-abi.exp
+++ b/gdb/testsuite/gdb.arch/altivec-abi.exp
@@ -27,7 +27,6 @@ if $tracelevel then {
 
 if {![istarget "powerpc*"] || [skip_altivec_tests]} then {
     verbose "Skipping altivec abi tests."
-    verbose -log "Skipping altivec abi tests."
     return
 }
 
diff --git a/gdb/testsuite/gdb.arch/altivec-regs.exp b/gdb/testsuite/gdb.arch/altivec-regs.exp
index 91f749a..b8d8dc0 100644
--- a/gdb/testsuite/gdb.arch/altivec-regs.exp
+++ b/gdb/testsuite/gdb.arch/altivec-regs.exp
@@ -30,7 +30,6 @@ set bug_id 0
 
 if {![istarget "powerpc*"] || [skip_altivec_tests]} then {
     verbose "Skipping altivec register tests."
-    verbose -log "Skipping altivec register tests."
     return
 }
 
diff --git a/gdb/testsuite/gdb.arch/vsx-regs.exp b/gdb/testsuite/gdb.arch/vsx-regs.exp
index 006eb6d..18def60 100644
--- a/gdb/testsuite/gdb.arch/vsx-regs.exp
+++ b/gdb/testsuite/gdb.arch/vsx-regs.exp
@@ -32,7 +32,6 @@ set bug_id 0
 
 if {![istarget "powerpc*"] || [skip_vsx_tests]} then {
     verbose "Skipping vsx register tests."
-    verbose -log "Skipping vsx register tests."
     return
 }
 

Re: [commit] remove extra verbose -log calls in testcases

[Joel Brobecker]

> As noticed by Joel in my FPSCR testcase, it's not usual to call verbose
> twice. Committed the following.

I ended up having a look at the dejagnu documentation about this verbose
procedure, and here is what it says:

    | Verbose Procedure
    | 
    | Test cases can use this function to issue helpful messages
    | depending on the number of --verbose options on the runtest
    | command line. It prints string if the value of the variable
    | verbose is higher than or equal to the optional number. The
    | default value for number is 1. Use the optional -log argument to
    | cause string to always be added to the log file, even if it won't
    | be printed. Use the optional -x argument to log the test results
    | into a parsable XML file. Use the optional -n argument to print
    | string without a trailing newline. Use the optional -- argument
    | if string begins with "-".
    | 
    | verbose(-log -x -n -r string number);

So I think it is indeed wrong to have duplicate calls to verbose.

I like the fact that -log causes it to always be printed to the log
file, but I don't see this as very important... Since the vast majority
of the testcase I inspected seem to use the verbose procedure without
-log, at least we're consistent...

-- 
Joel