From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [commit] remove extra verbose -log calls in testcases
Date: Fri, 05 Sep 2008 22:21:00 -0000 [thread overview]
Message-ID: <20080905222111.GE15267@adacore.com> (raw)
In-Reply-To: <1220642085.10056.21.camel@localhost.localdomain>
> As noticed by Joel in my FPSCR testcase, it's not usual to call verbose
> twice. Committed the following.
I ended up having a look at the dejagnu documentation about this verbose
procedure, and here is what it says:
| Verbose Procedure
|
| Test cases can use this function to issue helpful messages
| depending on the number of --verbose options on the runtest
| command line. It prints string if the value of the variable
| verbose is higher than or equal to the optional number. The
| default value for number is 1. Use the optional -log argument to
| cause string to always be added to the log file, even if it won't
| be printed. Use the optional -x argument to log the test results
| into a parsable XML file. Use the optional -n argument to print
| string without a trailing newline. Use the optional -- argument
| if string begins with "-".
|
| verbose(-log -x -n -r string number);
So I think it is indeed wrong to have duplicate calls to verbose.
I like the fact that -log causes it to always be printed to the log
file, but I don't see this as very important... Since the vast majority
of the testcase I inspected seem to use the verbose procedure without
-log, at least we're consistent...
--
Joel
prev parent reply other threads:[~2008-09-05 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 19:59 Thiago Jung Bauermann
2008-09-05 22:21 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905222111.GE15267@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox