From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15870 invoked by alias); 5 Sep 2008 22:21:51 -0000 Received: (qmail 15861 invoked by uid 22791); 5 Sep 2008 22:21:50 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 22:21:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2A8D12A971D; Fri, 5 Sep 2008 18:21:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6xrPxA+XrJm8; Fri, 5 Sep 2008 18:21:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C42232A9705; Fri, 5 Sep 2008 18:21:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 692FAE7ACD; Sat, 6 Sep 2008 00:21:11 +0200 (CEST) Date: Fri, 05 Sep 2008 22:21:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [commit] remove extra verbose -log calls in testcases Message-ID: <20080905222111.GE15267@adacore.com> References: <1220642085.10056.21.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1220642085.10056.21.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00112.txt.bz2 > As noticed by Joel in my FPSCR testcase, it's not usual to call verbose > twice. Committed the following. I ended up having a look at the dejagnu documentation about this verbose procedure, and here is what it says: | Verbose Procedure | | Test cases can use this function to issue helpful messages | depending on the number of --verbose options on the runtest | command line. It prints string if the value of the variable | verbose is higher than or equal to the optional number. The | default value for number is 1. Use the optional -log argument to | cause string to always be added to the log file, even if it won't | be printed. Use the optional -x argument to log the test results | into a parsable XML file. Use the optional -n argument to print | string without a trailing newline. Use the optional -- argument | if string begins with "-". | | verbose(-log -x -n -r string number); So I think it is indeed wrong to have duplicate calls to verbose. I like the fact that -log causes it to always be printed to the log file, but I don't see this as very important... Since the vast majority of the testcase I inspected seem to use the verbose procedure without -log, at least we're consistent... -- Joel