From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org
Subject: Re: Printing decimal128 types out of registers
Date: Wed, 30 Jan 2008 18:38:00 -0000 [thread overview]
Message-ID: <1201717824.11950.252.camel@localhost.localdomain> (raw)
In-Reply-To: <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl>
On Wed, 2008-01-30 at 19:11 +0100, Mark Kettenis wrote:
> > Is this ok?
>
> Looks mostly reasonable to me, but I don't see why you need
> ppc_dl0_upper_regnum, and ppc_dl15_regnum.
ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you
saying that given it always has the value of ppc_fp0_regnum, I should
use that instead? Could be, but then there's the lack of symmetry in
using an fp variable in dl-related code. But that's minor.
ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons,
since there's ppc_ev31_regnum. But it can be removed (specially if the
later is removed as well as you suggested).
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-01-30 18:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 19:33 [PATCH] PPC - Printing Decimal 128 " Luis Machado
2007-11-26 21:40 ` Luis Machado
2007-12-26 12:42 ` [PING] " Luis Machado
2008-01-17 19:03 ` Printing decimal128 " Luis Machado
2008-01-17 19:36 ` Thiago Jung Bauermann
2008-01-18 15:43 ` Luis Machado
2008-01-18 16:12 ` Mark Kettenis
2008-01-18 16:38 ` Luis Machado
2008-01-18 17:20 ` Mark Kettenis
2008-01-18 18:52 ` Luis Machado
2008-01-18 19:54 ` Mark Kettenis
2008-01-19 0:04 ` Daniel Jacobowitz
2008-01-21 14:55 ` Thiago Jung Bauermann
2008-01-21 17:31 ` Mark Kettenis
2008-01-23 15:39 ` Thiago Jung Bauermann
2008-01-21 17:54 ` Daniel Jacobowitz
2008-01-23 15:11 ` Thiago Jung Bauermann
2008-01-23 15:20 ` Daniel Jacobowitz
2008-01-23 16:56 ` Thiago Jung Bauermann
2008-01-30 15:46 ` Thiago Jung Bauermann
2008-01-30 16:45 ` Thiago Jung Bauermann
2008-01-30 18:27 ` Mark Kettenis
2008-01-30 18:38 ` Thiago Jung Bauermann [this message]
2008-01-30 20:28 ` Mark Kettenis
2008-01-30 21:26 ` Thiago Jung Bauermann
2008-01-30 21:39 ` Ulrich Weigand
2008-01-31 14:47 ` Thiago Jung Bauermann
2008-01-31 15:06 ` Ulrich Weigand
2008-01-30 21:42 ` Mark Kettenis
2008-01-30 23:03 ` Eli Zaretskii
2008-01-31 15:44 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201717824.11950.252.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox