Re: Printing decimal128 types out of registers

Mark Kettenis
2008-01-30T19:24:51Z

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org
> Date: Wed, 30 Jan 2008 16:30:24 -0200
> X-XS4ALL-DNSBL-Checked: mxdrop125.xs4all.nl checked 32.104.18.26 against DNS blacklists
> X-CNFS-Analysis: v=1.0 c=1 a=IUiVJ43dWc4A:15 a=QNG5IYMOGygA:10
> a=32zfua8Jo/FoLADJBaZU6A==:17 a=TUX4L2OknBXofI9ZbzkA:9
> a=kQGOXI3pO-Bphn8UE8AA:7 a=lLSZ6TJ2nqydr84DMUAV6pK8bCYA:4
> a=LY0hPdMaydYA:10
> X-Virus-Scanned: by XS4ALL Virus Scanner
> X-XS4ALL-Spam-Score: -0.0 () SPF_PASS
> X-XS4ALL-Spam: NO
> Envelope-To: mark.kettenis@xs4all.nl
>
> On Wed, 2008-01-30 at 19:11 +0100, Mark Kettenis wrote:
> > > Is this ok?
> >
> > Looks mostly reasonable to me, but I don't see why you need
> > ppc_dl0_upper_regnum, and ppc_dl15_regnum.
>
> ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you
> saying that given it always has the value of ppc_fp0_regnum, I should
> use that instead? Could be, but then there's the lack of symmetry in
> using an fp variable in dl-related code. But that's minor.

Yes, I think that using ppc_fp0_regnum is better, since it makes it
explicit in the code that the decimal float (pseudo) registers are
just a different representation of the floating point registers.

> ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons,
> since there's ppc_ev31_regnum. But it can be removed (specially if the
> later is removed as well as you suggested).

Yes, that was what I was thinking. The less uneeded clutter, the better.