From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: bauerman@br.ibm.com
Cc: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org
Subject: Re: Printing decimal128 types out of registers
Date: Wed, 30 Jan 2008 18:27:00 -0000 [thread overview]
Message-ID: <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <1201706206.11950.237.camel@localhost.localdomain> (message from Thiago Jung Bauermann on Wed, 30 Jan 2008 13:16:46 -0200)
> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Date: Wed, 30 Jan 2008 13:16:46 -0200
>
> > If this is too complicated, I wouldn't argue against a patch that just
> > added them if the floating point regsiters are present. Seems like it
> > won't be useful on a lot of processors though.
>
> Actually, this option is more appropriate. I have recently learned that
> there are some regular float instructions which can be directly used in
> DFP values stored in FP registers, like fabs, fneg and the other
> floating point move instructions. So it is very useful to have the
> pseudo-registers around even without specific DFP hardware.
>
> The attached patch is a rework of Luis' patch, with the following
> modifications:
>
> - don't use tdesc XML machinery to define the DFP pseudo-regs;
> - fixed logic in rs6000_pseudo_register_reggroup_p as noted by Daniel;
> - put DFP pseudo-regs in float register group;
> - the DFP pseudo-regs don't show up if there's no FPU;
> - reorganized the pseudo_register_{read,write} functions: there's now
> a generic one which concentrates the gdb_asserts and checking, and
> calls either the SPE or DFP as appropriate.
> - documentation: mention the DFP pseudo-regs in the Decimal Floating
> Point subsection, and created a PowerPC architecture subsection to
> talk about them in more detail. I had to rename the PowerPC Embedded
> section to avoid a node name conflict.
>
> This patch is on top of the SPE macro cleanup patch which I just posted:
>
> http://sourceware.org/ml/gdb-patches/2008-01/msg00794.html
>
> Is this ok?
Looks mostly reasonable to me, but I don't see why you need
ppc_dl0_upper_regnum, and ppc_dl15_regnum.
next prev parent reply other threads:[~2008-01-30 18:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 19:33 [PATCH] PPC - Printing Decimal 128 " Luis Machado
2007-11-26 21:40 ` Luis Machado
2007-12-26 12:42 ` [PING] " Luis Machado
2008-01-17 19:03 ` Printing decimal128 " Luis Machado
2008-01-17 19:36 ` Thiago Jung Bauermann
2008-01-18 15:43 ` Luis Machado
2008-01-18 16:12 ` Mark Kettenis
2008-01-18 16:38 ` Luis Machado
2008-01-18 17:20 ` Mark Kettenis
2008-01-18 18:52 ` Luis Machado
2008-01-18 19:54 ` Mark Kettenis
2008-01-19 0:04 ` Daniel Jacobowitz
2008-01-21 14:55 ` Thiago Jung Bauermann
2008-01-21 17:31 ` Mark Kettenis
2008-01-23 15:39 ` Thiago Jung Bauermann
2008-01-21 17:54 ` Daniel Jacobowitz
2008-01-23 15:11 ` Thiago Jung Bauermann
2008-01-23 15:20 ` Daniel Jacobowitz
2008-01-23 16:56 ` Thiago Jung Bauermann
2008-01-30 15:46 ` Thiago Jung Bauermann
2008-01-30 16:45 ` Thiago Jung Bauermann
2008-01-30 18:27 ` Mark Kettenis [this message]
2008-01-30 18:38 ` Thiago Jung Bauermann
2008-01-30 20:28 ` Mark Kettenis
2008-01-30 21:26 ` Thiago Jung Bauermann
2008-01-30 21:39 ` Ulrich Weigand
2008-01-31 14:47 ` Thiago Jung Bauermann
2008-01-31 15:06 ` Ulrich Weigand
2008-01-30 21:42 ` Mark Kettenis
2008-01-30 23:03 ` Eli Zaretskii
2008-01-31 15:44 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=bauerman@br.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox