From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31552 invoked by alias); 30 Jan 2008 18:31:11 -0000 Received: (qmail 31543 invoked by uid 22791); 30 Jan 2008 18:31:10 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 18:30:40 +0000 Received: from mailhub3.br.ibm.com (unknown [9.18.232.110]) by igw3.br.ibm.com (Postfix) with ESMTP id 7E2D53900E9 for ; Wed, 30 Jan 2008 16:21:37 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0UIUTR62134110 for ; Wed, 30 Jan 2008 16:30:30 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0UIUS2l021117 for ; Wed, 30 Jan 2008 16:30:29 -0200 Received: from [9.12.235.82] ([9.12.235.82]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m0UIUQAC021061; Wed, 30 Jan 2008 16:30:27 -0200 Subject: Re: Printing decimal128 types out of registers From: Thiago Jung Bauermann To: Mark Kettenis Cc: drow@false.org, luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org In-Reply-To: <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl> References: <1200927274.32125.36.camel@localhost.localdomain> <200801211730.m0LHUGbu021315@brahms.sibelius.xs4all.nl> <1194460412.6686.34.camel@localhost> <1200596592.27321.20.camel@gargoyle> <1200598580.32125.11.camel@localhost.localdomain> <1200670954.10815.1.camel@gargoyle> <20080119000423.GA15057@caradoc.them.org> <1200927274.32125.36.camel@localhost.localdomain> <20080121175413.GA25254@caradoc.them.org> <1201101039.11950.56.camel@localhost.localdomain> <20080123152007.GA8286@caradoc.them.org> <1201706206.11950.237.camel@localhost.localdomain> <200801301811.m0UIBJS0006582@brahms.sibelius.xs4all.nl> Content-Type: text/plain Date: Wed, 30 Jan 2008 18:38:00 -0000 Message-Id: <1201717824.11950.252.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00814.txt.bz2 On Wed, 2008-01-30 at 19:11 +0100, Mark Kettenis wrote: > > Is this ok? > > Looks mostly reasonable to me, but I don't see why you need > ppc_dl0_upper_regnum, and ppc_dl15_regnum. ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you saying that given it always has the value of ppc_fp0_regnum, I should use that instead? Could be, but then there's the lack of symmetry in using an fp variable in dl-related code. But that's minor. ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons, since there's ppc_ev31_regnum. But it can be removed (specially if the later is removed as well as you suggested). -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center