* ARM Simulator build broken
@ 2004-11-16 12:40 Richard Earnshaw
2004-11-16 15:24 ` Richard Earnshaw
0 siblings, 1 reply; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-16 12:40 UTC (permalink / raw)
To: Hans-Peter Nilsson, gdb-patches
2004-11-16 Hans-Peter Nilsson <hp@axis.com>
* sim-config.c (sim_config): Recognize when a bfd has unspecified
endian information.
* Make-common.in (sim-load.o): Depend on $(sim_main_headers) and
$(remote_sim_h) too.
(sim_main_headers): Add sim-utils.h.
This patch breaks the ARM simulator build. The patch introduces a
dependency of sim-load on sim-main.h which isn't needed, and the ARM
simulator does not provide such a header (since it doesn't build any of
the other files in sim/common).
R.
--
Richard Earnshaw Email: Richard.Earnshaw@arm.com
ARM Ltd Phone: +44 1223 400569 (Direct + VoiceMail)
110 Fulbourn Road Switchboard: +44 1223 400400
Cherry Hinton Fax: +44 1223 400410
Cambridge CB1 9NJ Web: http://www.arm.com/
UK
----------------------------------------------------------------
This e-mail message is intended for the addressee(s) only and may
contain information that is the property of, and/or subject to a
confidentiality agreement between the intended recipient(s), their
organisation and/or the ARM Group of Companies. If you are not an
intended recipient of this e-mail message, you should not read, copy,
forward or otherwise distribute or further disclose the information in
it; misuse of the contents of this e-mail message may violate various
laws in your state, country or jurisdiction. If you have received this
e-mail message in error, please contact the originator of this e-mail
message via e-mail and delete all copies of this message from your
computer or network, thank you.
----------------------------------------------------------------
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: ARM Simulator build broken
2004-11-16 12:40 ARM Simulator build broken Richard Earnshaw
@ 2004-11-16 15:24 ` Richard Earnshaw
2004-11-16 15:36 ` Hans-Peter Nilsson
0 siblings, 1 reply; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-16 15:24 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, 2004-11-16 at 12:40, Richard Earnshaw wrote:
> 2004-11-16 Hans-Peter Nilsson <hp@axis.com>
>
> * sim-config.c (sim_config): Recognize when a bfd has unspecified
> endian information.
>
> * Make-common.in (sim-load.o): Depend on $(sim_main_headers) and
> $(remote_sim_h) too.
> (sim_main_headers): Add sim-utils.h.
>
> This patch breaks the ARM simulator build. The patch introduces a
> dependency of sim-load on sim-main.h which isn't needed, and the ARM
> simulator does not provide such a header (since it doesn't build any of
> the other files in sim/common).
>
> R.
Here's my proposed patch:
<date> Richard Earnshaw <rearnsha@arm.com>
* Make-common.in (sim_basics_headers): New.
(sim_main_headers): Move basics headers and sub-dependencies
to sim_basics_headers). Add the dependencies through that.
(sim-load.c): Depend on sim_basics_headers not
sim_main_headers.
OK?
[-- Attachment #2: sim.patch --]
[-- Type: text/x-patch, Size: 2351 bytes --]
Index: Make-common.in
===================================================================
RCS file: /cvs/src/src/sim/common/Make-common.in,v
retrieving revision 1.14
diff -p -r1.14 Make-common.in
*** Make-common.in 16 Nov 2004 07:02:26 -0000 1.14
--- Make-common.in 16 Nov 2004 15:20:21 -0000
*************** sim_main_headers = \
*** 300,322 ****
sim-main.h \
$(srccom)/sim-assert.h \
$(srccom)/sim-base.h \
- $(srccom)/sim-basics.h \
- $(srccom)/sim-config.h \
$(srccom)/sim-cpu.h \
$(srccom)/sim-engine.h \
$(srccom)/sim-events.h \
- $(srccom)/sim-inline.h \
$(srccom)/sim-memopt.h \
$(srccom)/sim-model.h \
$(srccom)/sim-module.h \
$(srccom)/sim-profile.h \
- $(srccom)/sim-signal.h \
$(srccom)/sim-trace.h \
- $(srccom)/sim-utils.h \
$(srccom)/sim-watch.h \
! tconfig.h \
$(SIM_EXTRA_DEPS)
# Exported version of sim_main_headers.
SIM_MAIN_DEPS = \
$(sim_main_headers)
--- 300,329 ----
sim-main.h \
$(srccom)/sim-assert.h \
$(srccom)/sim-base.h \
$(srccom)/sim-cpu.h \
$(srccom)/sim-engine.h \
$(srccom)/sim-events.h \
$(srccom)/sim-memopt.h \
$(srccom)/sim-model.h \
$(srccom)/sim-module.h \
$(srccom)/sim-profile.h \
$(srccom)/sim-trace.h \
$(srccom)/sim-watch.h \
! $(sim_basics_headers) \
$(SIM_EXTRA_DEPS)
+ sim_basics_headers = \
+ $(srccom)/sim-basics.h \
+ tconfig.h \
+ $(srccom)/sim-config.h \
+ $(srccom)/sim-inline.h \
+ $(srccom)/sim-types.h \
+ $(srccom)/sim-bits.h \
+ $(srccom)/sim-endian.h \
+ $(srccom)/sim-signal.h \
+ $(srccom)/sim-arange.h \
+ $(srccom)/sim-utils.h
+
# Exported version of sim_main_headers.
SIM_MAIN_DEPS = \
$(sim_main_headers)
*************** sim-utils.o: $(srccom)/sim-utils.c $(sim
*** 473,479 ****
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_main_headers) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
--- 480,486 ----
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_basics_headers) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-16 15:24 ` Richard Earnshaw
@ 2004-11-16 15:36 ` Hans-Peter Nilsson
2004-11-17 15:04 ` Richard Earnshaw
0 siblings, 1 reply; 13+ messages in thread
From: Hans-Peter Nilsson @ 2004-11-16 15:36 UTC (permalink / raw)
To: rearnsha; +Cc: hans-peter.nilsson, gdb-patches
> From: Richard Earnshaw <rearnsha@gcc.gnu.org>
> Cc: gdb-patches@sources.redhat.com
> Here's my proposed patch:
>
> <date> Richard Earnshaw <rearnsha@arm.com>
>
> * Make-common.in (sim_basics_headers): New.
> (sim_main_headers): Move basics headers and sub-dependencies
> to sim_basics_headers). Add the dependencies through that.
> (sim-load.c): Depend on sim_basics_headers not
> sim_main_headers.
>
> OK?
I was preparing almost the same patch, just naming the macro
sim_basics_h_headers!
BTW, you shouldn't have edited out sim-arange.c, a gcc -MM says
it's actually included from sim-basics.h (and from looking at
the code). For the same reason sim-assert.h should be in
sim_basics_headers. Maybe all files should use the
$(sim-assert_h) et al macros.
brgds, H-P
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-16 15:36 ` Hans-Peter Nilsson
@ 2004-11-17 15:04 ` Richard Earnshaw
2004-11-17 16:06 ` Richard Earnshaw
0 siblings, 1 reply; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-17 15:04 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: gdb-patches
On Tue, 2004-11-16 at 15:35, Hans-Peter Nilsson wrote:
> > From: Richard Earnshaw <rearnsha@gcc.gnu.org>
> > Cc: gdb-patches@sources.redhat.com
>
> > Here's my proposed patch:
> >
> > <date> Richard Earnshaw <rearnsha@arm.com>
> >
> > * Make-common.in (sim_basics_headers): New.
> > (sim_main_headers): Move basics headers and sub-dependencies
> > to sim_basics_headers). Add the dependencies through that.
> > (sim-load.c): Depend on sim_basics_headers not
> > sim_main_headers.
> >
> > OK?
>
> I was preparing almost the same patch, just naming the macro
> sim_basics_h_headers!
>
> BTW, you shouldn't have edited out sim-arange.c, a gcc -MM says
> it's actually included from sim-basics.h (and from looking at
> the code). For the same reason sim-assert.h should be in
> sim_basics_headers. Maybe all files should use the
> $(sim-assert_h) et al macros.
The list of headers I used was the list directly in sim-basics.h. I
only moved existing includes from sim_main_headers and then added
further ones at the first level that were obviously missing. So if it's
wrong now it was wrong before.
The best way to do all this is to define a series of macros
sim-basics_h, sim-assert-h etc, and for each of these to list the macros
that form the direct dependencies.
But that's a fair bit of work... :-( ... and it needs active
maintenance to keep it up to date.
R.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-17 15:04 ` Richard Earnshaw
@ 2004-11-17 16:06 ` Richard Earnshaw
2004-11-17 18:25 ` Hans-Peter Nilsson
2004-11-24 18:42 ` Alexandre Oliva
0 siblings, 2 replies; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-17 16:06 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Wed, 2004-11-17 at 15:03, Richard Earnshaw wrote:
> On Tue, 2004-11-16 at 15:35, Hans-Peter Nilsson wrote:
> > > From: Richard Earnshaw <rearnsha@gcc.gnu.org>
> > > Cc: gdb-patches@sources.redhat.com
> >
> > > Here's my proposed patch:
> > >
> > > <date> Richard Earnshaw <rearnsha@arm.com>
> > >
> > > * Make-common.in (sim_basics_headers): New.
> > > (sim_main_headers): Move basics headers and sub-dependencies
> > > to sim_basics_headers). Add the dependencies through that.
> > > (sim-load.c): Depend on sim_basics_headers not
> > > sim_main_headers.
> > >
> > > OK?
> >
> > I was preparing almost the same patch, just naming the macro
> > sim_basics_h_headers!
> >
> > BTW, you shouldn't have edited out sim-arange.c, a gcc -MM says
> > it's actually included from sim-basics.h (and from looking at
> > the code). For the same reason sim-assert.h should be in
> > sim_basics_headers. Maybe all files should use the
> > $(sim-assert_h) et al macros.
>
> The list of headers I used was the list directly in sim-basics.h. I
> only moved existing includes from sim_main_headers and then added
> further ones at the first level that were obviously missing. So if it's
> wrong now it was wrong before.
>
> The best way to do all this is to define a series of macros
> sim-basics_h, sim-assert-h etc, and for each of these to list the macros
> that form the direct dependencies.
>
> But that's a fair bit of work... :-( ... and it needs active
> maintenance to keep it up to date.
>
> R.
Attached is a revised version of the patch that implements this for
sim-*.h. Really further work should be done so that the C files depend
on the correct headers rather than all depending on sim_main_headers.
R.
[-- Attachment #2: sim2.patch --]
[-- Type: text/x-patch, Size: 4461 bytes --]
Index: Make-common.in
===================================================================
RCS file: /cvs/src/src/sim/common/Make-common.in,v
retrieving revision 1.14
diff -p -r1.14 Make-common.in
*** Make-common.in 16 Nov 2004 07:02:26 -0000 1.14
--- Make-common.in 17 Nov 2004 16:02:17 -0000
*************** stamp-tvals: gentmap
*** 298,341 ****
sim_main_headers = \
sim-main.h \
! $(srccom)/sim-assert.h \
! $(srccom)/sim-base.h \
! $(srccom)/sim-basics.h \
! $(srccom)/sim-config.h \
! $(srccom)/sim-cpu.h \
! $(srccom)/sim-engine.h \
! $(srccom)/sim-events.h \
! $(srccom)/sim-inline.h \
! $(srccom)/sim-memopt.h \
! $(srccom)/sim-model.h \
! $(srccom)/sim-module.h \
! $(srccom)/sim-profile.h \
! $(srccom)/sim-signal.h \
! $(srccom)/sim-trace.h \
! $(srccom)/sim-utils.h \
! $(srccom)/sim-watch.h \
! tconfig.h \
$(SIM_EXTRA_DEPS)
# Exported version of sim_main_headers.
SIM_MAIN_DEPS = \
$(sim_main_headers)
sim-assert_h = $(srccom)/sim-assert.h
! sim-endian_h = $(srccom)/sim-endian.h
! sim-n-endian_h = $(srccom)/sim-n-endian.h
! sim-arange_h = $(srccom)/sim-arange.h
! sim-bits_h = $(srccom)/sim-bits.h
sim-config_h = $(srccom)/sim-config.h
- sim-n-bits_h = $(srccom)/sim-n-bits.h
sim-core_h = $(srccom)/sim-core.h
! sim-n-core_h = $(srccom)/sim-n-core.h
sim-engine_h = $(srccom)/sim-engine.h
sim-events_h = $(srccom)/sim-events.h
sim-fpu_h = $(srccom)/sim-fpu.h
sim-io_h = $(srccom)/sim-io.h
sim-options_h = $(srccom)/sim-options.h
sim-signal_h = $(srccom)/sim-signal.h
hw-alloc_h = $(srccom)/hw-alloc.h
hw-base_h = $(srccom)/hw-base.h
--- 298,374 ----
sim_main_headers = \
sim-main.h \
! $(sim-assert_h) \
! $(sim-base_h) \
! $(sim-cpu_h) \
! $(sim-engine_h) \
! $(sim-events_h) \
! $(sim-memopt_h) \
! $(sim-model_h) \
! $(sim-module_h) \
! $(sim-profile_h) \
! $(sim-trace_h) \
! $(sim-watch_h) \
! $(sim-basics_h) \
$(SIM_EXTRA_DEPS)
# Exported version of sim_main_headers.
SIM_MAIN_DEPS = \
$(sim_main_headers)
+ sim-alu_h = $(srccom)/sim-alu.h
+ sim-arange_h = $(srccom)/sim-arange.h \
+ $(srccom)/sim-arange.c
sim-assert_h = $(srccom)/sim-assert.h
! sim-base_h = $(srccom)/sim-base.h \
! $(sim-module_h) \
! $(sim-trace_h) \
! $(sim-core_h) \
! $(sim-events_h) \
! $(sim-profile_h) \
! $(sim-model_h) \
! $(sim-io_h) \
! $(sim-engine_h) \
! $(sim-watch_h) \
! $(sim-memopt_h) \
! $(sim-cpu_h)
! sim-basics_h = $(srccom)/sim-basics.h \
! cconfig_h \
! tconfig_h \
! $(sim-config_h) \
! $(sim-inline_h) \
! $(sim-types_h) \
! $(sim-bits_h) \
! $(sim-endian_h) \
! $(sim-signal_h) \
! $(sim-arange_h) \
! $(sim-utils_h)
! sim-bits_h = $(srccom)/sim-bits.h \
! $(srccom)/sim-bits.c
sim-config_h = $(srccom)/sim-config.h
sim-core_h = $(srccom)/sim-core.h
! sim-cpu_h = $(srccom)/sim-cpu.h
! sim-endian_h = $(srccom)/sim-endian.h \
! $(srccom)/sim-endian.c
sim-engine_h = $(srccom)/sim-engine.h
sim-events_h = $(srccom)/sim-events.h
sim-fpu_h = $(srccom)/sim-fpu.h
+ sim-hw_h = $(srccom)/sim-hw.h
+ sim-inline_h = $(srccom)/sim-inline.h
sim-io_h = $(srccom)/sim-io.h
+ sim-memopt_h = $(srccom)/sim-memopt.h
+ sim-model_h = $(srccom)/sim-model.h
+ sim-module_h = $(srccom)/sim-module.h
+ sim-n-bits_h = $(srccom)/sim-n-bits.h
+ sim-n-core_h = $(srccom)/sim-n-core.h
+ sim-n-endian_h = $(srccom)/sim-n-endian.h
sim-options_h = $(srccom)/sim-options.h
+ sim-profile_h = $(srccom)/sim-profile.h
sim-signal_h = $(srccom)/sim-signal.h
+ sim-trace_h = $(srccom)/sim-trace.h
+ sim-types_h = $(srccom)/sim-types.h
+ sim-utils_h = $(srccom)/sim-utils.h
+ sim-watch_h = $(srccom)/sim-watch.h
hw-alloc_h = $(srccom)/hw-alloc.h
hw-base_h = $(srccom)/hw-base.h
*************** sim-utils.o: $(srccom)/sim-utils.c $(sim
*** 473,479 ****
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_main_headers) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
--- 506,512 ----
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_basics_h) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-17 16:06 ` Richard Earnshaw
@ 2004-11-17 18:25 ` Hans-Peter Nilsson
2004-11-17 20:38 ` Andrew Cagney
2004-11-24 18:42 ` Alexandre Oliva
1 sibling, 1 reply; 13+ messages in thread
From: Hans-Peter Nilsson @ 2004-11-17 18:25 UTC (permalink / raw)
To: rearnsha; +Cc: hans-peter.nilsson, gdb-patches
> From: Richard Earnshaw <rearnsha@gcc.gnu.org>
> Date: Wed, 17 Nov 2004 16:06:19 +0000
> On Wed, 2004-11-17 at 15:03, Richard Earnshaw wrote:
> > On Tue, 2004-11-16 at 15:35, Hans-Peter Nilsson wrote:
> > > BTW, you shouldn't have edited out sim-arange.c, a gcc -MM says
> > > it's actually included from sim-basics.h (and from looking at
> > > the code). For the same reason sim-assert.h should be in
> > > sim_basics_headers. Maybe all files should use the
> > > $(sim-assert_h) et al macros.
> >
> > The list of headers I used was the list directly in sim-basics.h. I
> > only moved existing includes from sim_main_headers and then added
> > further ones at the first level that were obviously missing. So if it's
> > wrong now it was wrong before.
Yes, it *was* wrong before. :-) Many more were missing.
Less wrong with your patch. Anyway, you weren't that far off: I
got the list from "gcc -MM" with the rest of the command-line
from an arm-sim compilation of sim-load.c, but with the file a
single '#include "sim-basics.h"'. Notable thing missing:
sim-basics.h contains the specific lines
#include "gdb/callback.h"
#include "gdb/remote-sim.h"
Supposedly they were added at some point but dependencies were
for some reason or another not updated. It kind of makes the
occurrences of $(remote_sim_h) and $(callback_h) in .o rules
redundant...
> > The best way to do all this is to define a series of macros
> > sim-basics_h, sim-assert-h etc, and for each of these to list the macros
> > that form the direct dependencies.
Right, some are already there, but apparently unused in
sim_main_headers for unknown reasons, while the similar hw-*_h
macros are used in hw_main_h.
> > But that's a fair bit of work... :-( ... and it needs active
> > maintenance to keep it up to date.
> >
> > R.
>
> Attached is a revised version of the patch that implements this for
> sim-*.h.
Nice.
> Really further work should be done so that the C files depend
> on the correct headers rather than all depending on sim_main_headers.
Along the lines of the dep-am rule in bfd/Makefile.am, perhaps.
brgds, H-P
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-17 18:25 ` Hans-Peter Nilsson
@ 2004-11-17 20:38 ` Andrew Cagney
2004-11-18 0:08 ` Hans-Peter Nilsson
0 siblings, 1 reply; 13+ messages in thread
From: Andrew Cagney @ 2004-11-17 20:38 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: rearnsha, gdb-patches
Once, you two have agreed as to how to fix this, please check it in.
Andrew
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-17 20:38 ` Andrew Cagney
@ 2004-11-18 0:08 ` Hans-Peter Nilsson
2004-11-18 10:22 ` Richard Earnshaw
0 siblings, 1 reply; 13+ messages in thread
From: Hans-Peter Nilsson @ 2004-11-18 0:08 UTC (permalink / raw)
To: cagney; +Cc: hans-peter.nilsson, rearnsha, gdb-patches
> Date: Wed, 17 Nov 2004 15:38:27 -0500
> From: Andrew Cagney <cagney@gnu.org>
> Once, you two have agreed as to how to fix this, please check it in.
I agrew with Richard's recent patch.
brgds, H-P
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-18 0:08 ` Hans-Peter Nilsson
@ 2004-11-18 10:22 ` Richard Earnshaw
0 siblings, 0 replies; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-18 10:22 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: cagney, gdb-patches
On Thu, 2004-11-18 at 00:08, Hans-Peter Nilsson wrote:
> > Date: Wed, 17 Nov 2004 15:38:27 -0500
> > From: Andrew Cagney <cagney@gnu.org>
>
> > Once, you two have agreed as to how to fix this, please check it in.
>
> I agrew with Richard's recent patch.
>
> brgds, H-P
I've checked it in. Patch as previously posted.
2004-11-18 Richard Earnshaw <rearnsha@arm.com>
* Make-common.in (sim-*_h): Add rules for all sim headers. Also
add sub-dependencies for other sim files that they include.
(sim_main_headers): Use sim-*_h rules.
(sim-load.o): Depend on sim-basics_h, not sim_main_headers.
R.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-17 16:06 ` Richard Earnshaw
2004-11-17 18:25 ` Hans-Peter Nilsson
@ 2004-11-24 18:42 ` Alexandre Oliva
2004-11-25 10:31 ` Richard Earnshaw
2004-11-25 10:48 ` Richard Earnshaw
1 sibling, 2 replies; 13+ messages in thread
From: Alexandre Oliva @ 2004-11-24 18:42 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: Hans-Peter Nilsson, gdb-patches
On Nov 17, 2004, Richard Earnshaw <rearnsha@gcc.gnu.org> wrote:
> ! sim-basics_h = $(srccom)/sim-basics.h \
> ! cconfig_h \
> ! tconfig_h \
How are the cconfig_h and tconfig_h deps supposed to be resolved? I
don't get any other grep matches for these strings within sim, and
at least the frv sim won't build because sim-core.o needs some
cconfig_h file that doesn't exist. What was the idea here?
$(cconfig_h) and $(tconfig_h), maybe?
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: ARM Simulator build broken
2004-11-24 18:42 ` Alexandre Oliva
@ 2004-11-25 10:31 ` Richard Earnshaw
2004-11-25 10:48 ` Richard Earnshaw
1 sibling, 0 replies; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-25 10:31 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: Hans-Peter Nilsson, gdb-patches
On Wed, 2004-11-24 at 18:41, Alexandre Oliva wrote:
> On Nov 17, 2004, Richard Earnshaw <rearnsha@gcc.gnu.org> wrote:
>
> > ! sim-basics_h = $(srccom)/sim-basics.h \
> > ! cconfig_h \
> > ! tconfig_h \
>
> How are the cconfig_h and tconfig_h deps supposed to be resolved? I
> don't get any other grep matches for these strings within sim, and
> at least the frv sim won't build because sim-core.o needs some
> cconfig_h file that doesn't exist. What was the idea here?
> $(cconfig_h) and $(tconfig_h), maybe?
Possibly, but I think I'd intended these to be hard file dependencies on
tconfig.h and cconfig.h.
I've just noticed why my testing didn't pick this up... :-( The
dependency in sim-load.h is also wrong (sim_basics_h, not
sim-basics_h). Bah! I hate make...
I'll look into it and revise the patch.
R.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-24 18:42 ` Alexandre Oliva
2004-11-25 10:31 ` Richard Earnshaw
@ 2004-11-25 10:48 ` Richard Earnshaw
2004-11-29 18:27 ` Alexandre Oliva
1 sibling, 1 reply; 13+ messages in thread
From: Richard Earnshaw @ 2004-11-25 10:48 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: Hans-Peter Nilsson, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Wed, 2004-11-24 at 18:41, Alexandre Oliva wrote:
> On Nov 17, 2004, Richard Earnshaw <rearnsha@gcc.gnu.org> wrote:
>
> > ! sim-basics_h = $(srccom)/sim-basics.h \
> > ! cconfig_h \
> > ! tconfig_h \
>
> How are the cconfig_h and tconfig_h deps supposed to be resolved? I
> don't get any other grep matches for these strings within sim, and
> at least the frv sim won't build because sim-core.o needs some
> cconfig_h file that doesn't exist. What was the idea here?
> $(cconfig_h) and $(tconfig_h), maybe?
Can you test the attached patch? It fixes the dependency problems I now
see when I correct the sim-load.o dependency.
R.
* Make-common.in (sim-basics_h): Correct dependencies on
cconfig.h and tconfig.h
(sim-load.o): Correct typo in sim-basics_h dependency.
[-- Attachment #2: sim3.patch --]
[-- Type: text/x-patch, Size: 1363 bytes --]
Index: Make-common.in
===================================================================
RCS file: /cvs/src/src/sim/common/Make-common.in,v
retrieving revision 1.15
diff -p -r1.15 Make-common.in
*** Make-common.in 18 Nov 2004 10:21:39 -0000 1.15
--- Make-common.in 25 Nov 2004 10:43:54 -0000
*************** sim-base_h = $(srccom)/sim-base.h \
*** 333,340 ****
$(sim-memopt_h) \
$(sim-cpu_h)
sim-basics_h = $(srccom)/sim-basics.h \
! cconfig_h \
! tconfig_h \
$(sim-config_h) \
$(sim-inline_h) \
$(sim-types_h) \
--- 333,340 ----
$(sim-memopt_h) \
$(sim-cpu_h)
sim-basics_h = $(srccom)/sim-basics.h \
! ../common/cconfig.h \
! tconfig.h \
$(sim-config_h) \
$(sim-inline_h) \
$(sim-types_h) \
*************** sim-utils.o: $(srccom)/sim-utils.c $(sim
*** 506,512 ****
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim_basics_h) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
--- 506,512 ----
sim-watch.o: $(srccom)/sim-watch.c $(sim_main_headers)
$(CC) -c $(srccom)/sim-watch.c $(ALL_CFLAGS)
! sim-load.o: $(srccom)/sim-load.c $(callback_h) $(sim-basics_h) $(remote_sim_h)
$(CC) -c $(srccom)/sim-load.c $(ALL_CFLAGS)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ARM Simulator build broken
2004-11-25 10:48 ` Richard Earnshaw
@ 2004-11-29 18:27 ` Alexandre Oliva
0 siblings, 0 replies; 13+ messages in thread
From: Alexandre Oliva @ 2004-11-29 18:27 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: Hans-Peter Nilsson, gdb-patches
On Nov 25, 2004, Richard Earnshaw <rearnsha@gcc.gnu.org> wrote:
> Can you test the attached patch? It fixes the dependency problems I now
> see when I correct the sim-load.o dependency.
Thanks, I've just verified that it fixes the problem for a frv-elf
target sim.
> * Make-common.in (sim-basics_h): Correct dependencies on
> cconfig.h and tconfig.h
> (sim-load.o): Correct typo in sim-basics_h dependency.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2004-11-29 18:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-16 12:40 ARM Simulator build broken Richard Earnshaw
2004-11-16 15:24 ` Richard Earnshaw
2004-11-16 15:36 ` Hans-Peter Nilsson
2004-11-17 15:04 ` Richard Earnshaw
2004-11-17 16:06 ` Richard Earnshaw
2004-11-17 18:25 ` Hans-Peter Nilsson
2004-11-17 20:38 ` Andrew Cagney
2004-11-18 0:08 ` Hans-Peter Nilsson
2004-11-18 10:22 ` Richard Earnshaw
2004-11-24 18:42 ` Alexandre Oliva
2004-11-25 10:31 ` Richard Earnshaw
2004-11-25 10:48 ` Richard Earnshaw
2004-11-29 18:27 ` Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox