From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16198 invoked by alias); 17 Nov 2004 15:04:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16156 invoked from network); 17 Nov 2004 15:03:46 -0000 Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org with SMTP; 17 Nov 2004 15:03:46 -0000 Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id iAHF2mso017497; Wed, 17 Nov 2004 15:02:48 GMT Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1]) by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id iAHF3UgK022541; Wed, 17 Nov 2004 15:03:30 GMT Received: (from rearnsha@localhost) by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id iAHF3PTN022539; Wed, 17 Nov 2004 15:03:25 GMT X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@gcc.gnu.org using -f Subject: Re: ARM Simulator build broken From: Richard Earnshaw To: Hans-Peter Nilsson Cc: gdb-patches@sources.redhat.com In-Reply-To: <200411161535.iAGFZUN2014411@ignucius.se.axis.com> References: <200411161535.iAGFZUN2014411@ignucius.se.axis.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: GNU Message-Id: <1100703804.22014.42.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Wed, 17 Nov 2004 15:04:00 -0000 X-SW-Source: 2004-11/txt/msg00351.txt.bz2 On Tue, 2004-11-16 at 15:35, Hans-Peter Nilsson wrote: > > From: Richard Earnshaw > > Cc: gdb-patches@sources.redhat.com > > > Here's my proposed patch: > > > > Richard Earnshaw > > > > * Make-common.in (sim_basics_headers): New. > > (sim_main_headers): Move basics headers and sub-dependencies > > to sim_basics_headers). Add the dependencies through that. > > (sim-load.c): Depend on sim_basics_headers not > > sim_main_headers. > > > > OK? > > I was preparing almost the same patch, just naming the macro > sim_basics_h_headers! > > BTW, you shouldn't have edited out sim-arange.c, a gcc -MM says > it's actually included from sim-basics.h (and from looking at > the code). For the same reason sim-assert.h should be in > sim_basics_headers. Maybe all files should use the > $(sim-assert_h) et al macros. The list of headers I used was the list directly in sim-basics.h. I only moved existing includes from sim_main_headers and then added further ones at the first level that were obviously missing. So if it's wrong now it was wrong before. The best way to do all this is to define a series of macros sim-basics_h, sim-assert-h etc, and for each of these to list the macros that form the direct dependencies. But that's a fair bit of work... :-( ... and it needs active maintenance to keep it up to date. R.