Re: [PATCH] Cross target core debugging: host=i386, Target=PPC

[Kevin Buettner <kevinb@redhat.com>]

On Jul 30,  1:45pm, Martin Gadbois wrote:

> Kevin Buettner wrote:
> | On Jul 30, 11:32am, Daniel Jacobowitz wrote:
> |
> |
> |>+#define ELF_NGREG       48      /* includes nip, msr, lr, etc. */
> |>+#define ELF_NFPREG      33      /* includes fpscr */
> |>+#define ELF_NVRREG      33      /* includes vscr */
> |
> |
> | I noticed that the above are never actually referenced anywhere.  Can
> | we dispense with these defines?  Or are there some hard coded
> | constants lurking somewhere that should actually be defined in terms
> | of one or more of the above?
> 
> 
> They are:
> +
> +#define ELF_NGREG      48      /* includes nip, msr, lr, etc. */
> +#define ELF_NFPREG     33      /* includes fpscr */
> +#define ELF_NVRREG     33      /* includes vscr */
> +
> +typedef unsigned long elf_greg_t;
> +typedef elf_greg_t elf_gregset_t[ELF_NGREG];
> +
> +typedef double elf_fpreg_t;
> +typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG];
> +
> 
> Only NVRREG is not referenced.  It was copied as-is from ppc asm/elf.h.
> I don't think there's any other reference other than those above.

I should have made it clear(er) that I was referring to Daniel's
patch.  If you look at Daniel's patch, you'll see that ELF_NGREG,
ELFNFPREG, and ELF_NVRREG are defined but never referenced.

Kevin