From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30724 invoked by alias); 30 Jul 2002 17:55:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30711 invoked from network); 30 Jul 2002 17:55:27 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 30 Jul 2002 17:55:27 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g6UHhAl15644 for ; Tue, 30 Jul 2002 13:43:10 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g6UHtNu24990; Tue, 30 Jul 2002 13:55:23 -0400 Received: from romulus.sfbay.redhat.com (IDENT:3bUEbtSMetFyEtc7aVsqf+Ad1qSyYbuB@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6UHtIj26121; Tue, 30 Jul 2002 10:55:18 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6UHtGr15461; Tue, 30 Jul 2002 10:55:16 -0700 Date: Tue, 30 Jul 2002 11:24:00 -0000 From: Kevin Buettner Message-Id: <1020730175516.ZM15460@localhost.localdomain> In-Reply-To: Martin Gadbois "Re: [PATCH] Cross target core debugging: host=i386, Target=PPC" (Jul 30, 1:45pm) References: <3D45ACCC.9040803@colubris.com> <1020729215359.ZM11339@localhost.localdomain> <20020729164057.P3112@dr-evil.shagadelic.org> <20020729234439.GA666@nevyn.them.org> <20020730153200.GA619@nevyn.them.org> <1020730162739.ZM15174@localhost.localdomain> <3D46D0B9.7000309@colubris.com> To: Martin Gadbois , Kevin Buettner Subject: Re: [PATCH] Cross target core debugging: host=i386, Target=PPC Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00593.txt.bz2 On Jul 30, 1:45pm, Martin Gadbois wrote: > Kevin Buettner wrote: > | On Jul 30, 11:32am, Daniel Jacobowitz wrote: > | > | > |>+#define ELF_NGREG 48 /* includes nip, msr, lr, etc. */ > |>+#define ELF_NFPREG 33 /* includes fpscr */ > |>+#define ELF_NVRREG 33 /* includes vscr */ > | > | > | I noticed that the above are never actually referenced anywhere. Can > | we dispense with these defines? Or are there some hard coded > | constants lurking somewhere that should actually be defined in terms > | of one or more of the above? > > > They are: > + > +#define ELF_NGREG 48 /* includes nip, msr, lr, etc. */ > +#define ELF_NFPREG 33 /* includes fpscr */ > +#define ELF_NVRREG 33 /* includes vscr */ > + > +typedef unsigned long elf_greg_t; > +typedef elf_greg_t elf_gregset_t[ELF_NGREG]; > + > +typedef double elf_fpreg_t; > +typedef elf_fpreg_t elf_fpregset_t[ELF_NFPREG]; > + > > Only NVRREG is not referenced. It was copied as-is from ppc asm/elf.h. > I don't think there's any other reference other than those above. I should have made it clear(er) that I was referring to Daniel's patch. If you look at Daniel's patch, you'll see that ELF_NGREG, ELFNFPREG, and ELF_NVRREG are defined but never referenced. Kevin