Re: [PATCH] Cross target core debugging: host=i386, Target=PPC

[Daniel Jacobowitz <drow@mvista.com>]

On Tue, Jul 30, 2002 at 09:27:39AM -0700, Kevin Buettner wrote:
> On Jul 30, 11:32am, Daniel Jacobowitz wrote:
> 
> > +#define ELF_NGREG       48      /* includes nip, msr, lr, etc. */
> > +#define ELF_NFPREG      33      /* includes fpscr */
> > +#define ELF_NVRREG      33      /* includes vscr */
> 
> I noticed that the above are never actually referenced anywhere.  Can
> we dispense with these defines?  Or are there some hard coded
> constants lurking somewhere that should actually be defined in terms
> of one or more of the above?
> 
> Which reminds me...  I think the recent trend in gdb has been to use
> enums for constants rather than #define where possible.
> 
> Aside from the above concerns, your patch looks okay to me.

Oops, there's a thinko.  The block is:
+#define ELF_NGREG       48      /* includes nip, msr, lr, etc. */
+#define ELF_NFPREG      33      /* includes fpscr */
+#define ELF_NVRREG      33      /* includes vscr */
+
+#define ELF_GREGSET_SIZE (48 * 4)
+#define ELF_FPREGSET_SIZE (33 * 8)

The 48 and 33 there should be ELF_NGREG and ELF_NFPREG.

I'll commit it with that change (and enums, I suppose).  Thanks!  Now
to dust off ARM and i386 and do the same.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer