From: Kevin Buettner <kevinb@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>,
Kevin Buettner <kevinb@redhat.com>,
Martin Gadbois <martin.gadbois@colubris.com>,
gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Cross target core debugging: host=i386, Target=PPC
Date: Tue, 30 Jul 2002 10:47:00 -0000 [thread overview]
Message-ID: <1020730162739.ZM15174@localhost.localdomain> (raw)
In-Reply-To: Daniel Jacobowitz <drow@mvista.com> "Re: [PATCH] Cross target core debugging: host=i386, Target=PPC" (Jul 30, 11:32am)
On Jul 30, 11:32am, Daniel Jacobowitz wrote:
> +#define ELF_NGREG 48 /* includes nip, msr, lr, etc. */
> +#define ELF_NFPREG 33 /* includes fpscr */
> +#define ELF_NVRREG 33 /* includes vscr */
I noticed that the above are never actually referenced anywhere. Can
we dispense with these defines? Or are there some hard coded
constants lurking somewhere that should actually be defined in terms
of one or more of the above?
Which reminds me... I think the recent trend in gdb has been to use
enums for constants rather than #define where possible.
Aside from the above concerns, your patch looks okay to me.
Kevin
next prev parent reply other threads:[~2002-07-30 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-29 14:06 Martin Gadbois
2002-07-29 14:59 ` Kevin Buettner
2002-07-29 16:45 ` Jason R Thorpe
2002-07-29 18:50 ` Daniel Jacobowitz
2002-07-30 8:35 ` Daniel Jacobowitz
2002-07-30 8:50 ` Martin Gadbois
2002-07-30 12:09 ` Daniel Jacobowitz
2002-07-30 10:47 ` Kevin Buettner [this message]
2002-07-30 10:52 ` Martin Gadbois
2002-07-30 11:24 ` Kevin Buettner
2002-07-30 10:55 ` Daniel Jacobowitz
2002-07-30 12:05 ` Daniel Jacobowitz
2002-07-30 5:53 ` Martin Gadbois
2002-07-30 6:43 ` Martin Gadbois
2002-07-29 15:07 ` Kevin Buettner
2002-07-30 5:30 ` Martin Gadbois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020730162739.ZM15174@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=martin.gadbois@colubris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox