From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22929 invoked by alias); 30 Jul 2002 16:27:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22869 invoked from network); 30 Jul 2002 16:27:51 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 30 Jul 2002 16:27:51 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g6UGFZl24282 for ; Tue, 30 Jul 2002 12:15:36 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g6UGRhu24231; Tue, 30 Jul 2002 12:27:43 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6UGRfj25342; Tue, 30 Jul 2002 09:27:41 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6UGRd215175; Tue, 30 Jul 2002 09:27:39 -0700 Date: Tue, 30 Jul 2002 10:47:00 -0000 From: Kevin Buettner Message-Id: <1020730162739.ZM15174@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [PATCH] Cross target core debugging: host=i386, Target=PPC" (Jul 30, 11:32am) References: <3D45ACCC.9040803@colubris.com> <1020729215359.ZM11339@localhost.localdomain> <20020729164057.P3112@dr-evil.shagadelic.org> <20020729234439.GA666@nevyn.them.org> <20020730153200.GA619@nevyn.them.org> To: Daniel Jacobowitz , Kevin Buettner , Martin Gadbois , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Cross target core debugging: host=i386, Target=PPC MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00590.txt.bz2 On Jul 30, 11:32am, Daniel Jacobowitz wrote: > +#define ELF_NGREG 48 /* includes nip, msr, lr, etc. */ > +#define ELF_NFPREG 33 /* includes fpscr */ > +#define ELF_NVRREG 33 /* includes vscr */ I noticed that the above are never actually referenced anywhere. Can we dispense with these defines? Or are there some hard coded constants lurking somewhere that should actually be defined in terms of one or more of the above? Which reminds me... I think the recent trend in gdb has been to use enums for constants rather than #define where possible. Aside from the above concerns, your patch looks okay to me. Kevin