From: Kevin Buettner <kevinb@redhat.com>
To: Richard.Earnshaw@arm.com, Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] fix inferior_pid argument for arm-netbsd
Date: Thu, 10 Jan 2002 10:38:00 -0000 [thread overview]
Message-ID: <1020110183637.ZM4930@localhost.localdomain> (raw)
In-Reply-To: Richard Earnshaw <rearnsha@arm.com> "Re: [PATCH] fix inferior_pid argument for arm-netbsd" (Jan 10, 5:58pm)
On Jan 10, 5:58pm, Richard Earnshaw wrote:
> > > On Jan 9, 1:38pm, Richard Earnshaw wrote:
> > >
> > > > * armnbsd-nat.c (fetch_inferior_registers): Change inferior_pid ->
> > > > inferior_ptid.pid.
> > >
> > > Please don't do it this way. Use the accessor functions instead. I've
> > > looked over your patch, and in each case, you can simply use
> > >
> > > ptid_get_pid (inferior_ptid)
> > >
> >
> > Ah! I wasn't aware of the accessor functions. In fact, most targets are
> > using the macro GETPID (from defs.h). I've fixed the code to use that.
>
> I haven't heard anything further. Can I assume this is acceptable now, or
> do I have to go into limbo for another month?
It's fine. Check it in.
Kevin
next prev parent reply other threads:[~2002-01-10 18:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 5:39 Richard Earnshaw
[not found] ` <rearnsha@arm.com>
2002-01-09 7:40 ` Kevin Buettner
2002-01-09 7:54 ` Richard Earnshaw
2002-01-10 9:59 ` Richard Earnshaw
2002-01-10 10:38 ` Kevin Buettner [this message]
2002-01-12 9:47 ` [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS Kevin Buettner
2002-01-13 7:28 ` Richard Earnshaw
2002-01-13 9:32 ` Kevin Buettner
2002-01-13 10:40 ` Andrew Cagney
2002-01-13 11:08 ` Andrew Cagney
2002-01-13 11:48 ` Kevin Buettner
2002-01-13 11:54 ` Andrew Cagney
2002-01-14 2:18 ` Richard Earnshaw
2002-01-12 3:51 Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020110183637.ZM4930@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox