From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS
Date: Sun, 13 Jan 2002 11:54:00 -0000 [thread overview]
Message-ID: <3C41E5DC.1080904@cygnus.com> (raw)
In-Reply-To: <1020113194559.ZM26001@localhost.localdomain>
> On Jan 13, 2:08pm, Andrew Cagney wrote:
>
>> Subject: Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_RE
>
>> > + caller_fi.saved_regs = (CORE_ADDR *) xcalloc (1, SIZEOF_FRAME_SAVED_REGS);
>> > + old_chain = make_cleanup (xfree, caller_fi.saved_regs);
>> > + caller_fi.extra_info = xcalloc (1, sizeof (struct frame_extra_info));
>> > + make_cleanup (xfree, caller_fi.extra_info);
>> >
>> >
>> > That calloc() call caught my attention.
>> >
>> > Just call frame_saved_regs_zalloc() and frame_obstack_alloc(). Since all is on the frame obstack, worrying about cleanups is unnecessary.
>
>>
>> Hmm, no, sorry. That code is up to something wierd so it can't put the
>> stuff on the obstack. However, I would just use xmalloc().
>
>
> With an explicit memset following the allocation? (Otherwise, they're
> not initialized.)
Hmm (figures out what exactly that calloc() is doing). Yes, ok, doesn't
matter either way.
Andrew
next prev parent reply other threads:[~2002-01-13 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 5:39 [PATCH] fix inferior_pid argument for arm-netbsd Richard Earnshaw
[not found] ` <rearnsha@arm.com>
2002-01-09 7:40 ` Kevin Buettner
2002-01-09 7:54 ` Richard Earnshaw
2002-01-10 9:59 ` Richard Earnshaw
2002-01-10 10:38 ` Kevin Buettner
2002-01-12 9:47 ` [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS Kevin Buettner
2002-01-13 7:28 ` Richard Earnshaw
2002-01-13 9:32 ` Kevin Buettner
2002-01-13 10:40 ` Andrew Cagney
2002-01-13 11:08 ` Andrew Cagney
2002-01-13 11:48 ` Kevin Buettner
2002-01-13 11:54 ` Andrew Cagney [this message]
2002-01-14 2:18 ` Richard Earnshaw
2002-01-12 3:51 Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C41E5DC.1080904@cygnus.com \
--to=ac131313@cygnus.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox