From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23737 invoked by alias); 10 Jan 2002 18:38:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23691 invoked from network); 10 Jan 2002 18:38:11 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 10 Jan 2002 18:38:11 -0000 Received: from cse.cygnus.com (cse.sfbay.redhat.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA09083; Thu, 10 Jan 2002 10:38:07 -0800 (PST) Received: (from kev@localhost) by cse.cygnus.com (8.11.6/8.11.6) id g0AIabC04931; Thu, 10 Jan 2002 11:36:37 -0700 Date: Thu, 10 Jan 2002 10:38:00 -0000 From: Kevin Buettner Message-Id: <1020110183637.ZM4930@localhost.localdomain> In-Reply-To: Richard Earnshaw "Re: [PATCH] fix inferior_pid argument for arm-netbsd" (Jan 10, 5:58pm) References: <200201101758.RAA26999@cam-mail2.cambridge.arm.com> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: Richard.Earnshaw@arm.com, Kevin Buettner Subject: Re: [PATCH] fix inferior_pid argument for arm-netbsd Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-01/txt/msg00240.txt.bz2 On Jan 10, 5:58pm, Richard Earnshaw wrote: > > > On Jan 9, 1:38pm, Richard Earnshaw wrote: > > > > > > > * armnbsd-nat.c (fetch_inferior_registers): Change inferior_pid -> > > > > inferior_ptid.pid. > > > > > > Please don't do it this way. Use the accessor functions instead. I've > > > looked over your patch, and in each case, you can simply use > > > > > > ptid_get_pid (inferior_ptid) > > > > > > > Ah! I wasn't aware of the accessor functions. In fact, most targets are > > using the macro GETPID (from defs.h). I've fixed the code to use that. > > I haven't heard anything further. Can I assume this is acceptable now, or > do I have to go into limbo for another month? It's fine. Check it in. Kevin