* [PATCH] sparc-nat.c should not include itself
@ 2001-03-02 9:07 Kevin Buettner
2001-03-02 11:24 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2001-03-02 9:07 UTC (permalink / raw)
To: gdb-patches
I've just checked in the patch below under the "obvious-fix" rule. I've
tested this patch on sparc-sun-sunos4.1.4.
* sparc-nat.c (sparc-nat.c): Don't include.
Index: sparc-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-nat.c,v
retrieving revision 1.6
diff -u -p -r1.6 sparc-nat.c
--- sparc-nat.c 2001/03/01 01:39:21 1.6
+++ sparc-nat.c 2001/03/02 16:56:53
@@ -23,7 +23,6 @@
#include "inferior.h"
#include "target.h"
#include "gdbcore.h"
-#include "sparc-nat.c"
#include "regcache.h"
#include <signal.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc-nat.c should not include itself
2001-03-02 9:07 [PATCH] sparc-nat.c should not include itself Kevin Buettner
@ 2001-03-02 11:24 ` Michael Snyder
2001-03-02 11:49 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2001-03-02 11:24 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
Kevin Buettner wrote:
>
> I've just checked in the patch below under the "obvious-fix" rule. I've
> tested this patch on sparc-sun-sunos4.1.4.
>
> * sparc-nat.c (sparc-nat.c): Don't include.
The changelog comment is a little terse. How about "Don't include self"?
Otherwise it might not be clear to future generations what the change was.
>
> Index: sparc-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/sparc-nat.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 sparc-nat.c
> --- sparc-nat.c 2001/03/01 01:39:21 1.6
> +++ sparc-nat.c 2001/03/02 16:56:53
> @@ -23,7 +23,6 @@
> #include "inferior.h"
> #include "target.h"
> #include "gdbcore.h"
> -#include "sparc-nat.c"
> #include "regcache.h"
>
> #include <signal.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc-nat.c should not include itself
2001-03-02 11:24 ` Michael Snyder
@ 2001-03-02 11:49 ` Kevin Buettner
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2001-03-02 11:49 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
On Mar 2, 11:12am, Michael Snyder wrote:
> > I've just checked in the patch below under the "obvious-fix" rule. I've
> > tested this patch on sparc-sun-sunos4.1.4.
> >
> > * sparc-nat.c (sparc-nat.c): Don't include.
>
> The changelog comment is a little terse. How about "Don't include self"?
> Otherwise it might not be clear to future generations what the change was.
Thanks. I'll revise the comment as your suggest.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-03-02 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-02 9:07 [PATCH] sparc-nat.c should not include itself Kevin Buettner
2001-03-02 11:24 ` Michael Snyder
2001-03-02 11:49 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox