From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Snyder To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] sparc-nat.c should not include itself Date: Fri, 02 Mar 2001 11:24:00 -0000 Message-id: <3A9FF0A6.A3E81B0C@cygnus.com> References: <1010302170720.ZM22552@ocotillo.lan> X-SW-Source: 2001-03/msg00040.html Kevin Buettner wrote: > > I've just checked in the patch below under the "obvious-fix" rule. I've > tested this patch on sparc-sun-sunos4.1.4. > > * sparc-nat.c (sparc-nat.c): Don't include. The changelog comment is a little terse. How about "Don't include self"? Otherwise it might not be clear to future generations what the change was. > > Index: sparc-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/sparc-nat.c,v > retrieving revision 1.6 > diff -u -p -r1.6 sparc-nat.c > --- sparc-nat.c 2001/03/01 01:39:21 1.6 > +++ sparc-nat.c 2001/03/02 16:56:53 > @@ -23,7 +23,6 @@ > #include "inferior.h" > #include "target.h" > #include "gdbcore.h" > -#include "sparc-nat.c" > #include "regcache.h" > > #include