Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] sparc-nat.c should not include itself
Date: Fri, 02 Mar 2001 11:24:00 -0000	[thread overview]
Message-ID: <3A9FF0A6.A3E81B0C@cygnus.com> (raw)
In-Reply-To: <1010302170720.ZM22552@ocotillo.lan>

Kevin Buettner wrote:
> 
> I've just checked in the patch below under the "obvious-fix" rule.  I've
> tested this patch on sparc-sun-sunos4.1.4.
> 
>         * sparc-nat.c (sparc-nat.c): Don't include.

The changelog comment is a little terse.  How about "Don't include self"?
Otherwise it might not be clear to future generations what the change was.

> 
> Index: sparc-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/sparc-nat.c,v
> retrieving revision 1.6
> diff -u -p -r1.6 sparc-nat.c
> --- sparc-nat.c 2001/03/01 01:39:21     1.6
> +++ sparc-nat.c 2001/03/02 16:56:53
> @@ -23,7 +23,6 @@
>  #include "inferior.h"
>  #include "target.h"
>  #include "gdbcore.h"
> -#include "sparc-nat.c"
>  #include "regcache.h"
> 
>  #include <signal.h>


  reply	other threads:[~2001-03-02 11:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-02  9:07 Kevin Buettner
2001-03-02 11:24 ` Michael Snyder [this message]
2001-03-02 11:49   ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A9FF0A6.A3E81B0C@cygnus.com \
    --to=msnyder@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox