Re: [PATCH v2] gdb fix for catch-syscall.exp

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

> gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp
> 
> Powerpc is not reporting the
> 
>   Catchpoint 1 (returned from syscall execve),  ....
> 
> as expected.  The issue appears to be with the kernel not returning the
> expected result.  This patch marks the test failure as an xfail.
> 
> See gdb bugzilla https://sourceware.org/bugzilla/show_bug.cgi?id=28623

When we got rid of ChangeLogs, we agreed on the format:

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28623

when referring to bugzilla entries, let's use that.

> ---
>  gdb/testsuite/gdb.base/catch-syscall.exp | 38 ++++++++++++++++++++----
>  1 file changed, 32 insertions(+), 6 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp
> index cdd5e2aec47..76c5cfbc6d6 100644
> --- a/gdb/testsuite/gdb.base/catch-syscall.exp
> +++ b/gdb/testsuite/gdb.base/catch-syscall.exp
> @@ -127,7 +127,29 @@ proc check_return_from_syscall { syscall { pattern "" } } {
>      }
>  
>      set thistest "syscall $syscall has returned"
> -    gdb_test "continue" "Catchpoint $decimal \\(returned from syscall ${pattern}\\).*" $thistest
> +    if { $pattern eq "execve" } {
> +	gdb_test_multiple "continue" $thistest {
> +	    -re -wrap "Catchpoint $decimal \\(returned from syscall ${pattern}\\).*" {
> +		pass $thistest
> +		return 1
> +	    }
> +	    -re -wrap ".*Breakpoint $decimal, main .*" {
> +		# On Powerpc kernel does not report the returned from syscall

kernel -> the kernel
returned -> return

> +		# as expected by the test.  GDB bugzilla 28623.
> +		puts "CARLL test failed"

Leftover print.

Ok with those fixed.

Simon