From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OOlRNxTvs2FvaQAAWB0awg (envelope-from ) for ; Fri, 10 Dec 2021 19:21:40 -0500 Received: by simark.ca (Postfix, from userid 112) id DFDA71F0D0; Fri, 10 Dec 2021 19:21:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 695441EDEE for ; Fri, 10 Dec 2021 19:21:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A28D63857C72 for ; Sat, 11 Dec 2021 00:21:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A28D63857C72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639182099; bh=K31TqmbZX7w0gP9/xgExOuQ2tIgErG0vQTypb8euWpo=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tC4pqI+gFDdudrSKsoXw7lI9CxBoPMEQ6Vnh7S3uPCEDIzFxdJqpPQc/B77MsCj6X gVPj1IrQtGRGcawXocwBlQVr23PLoN/yfTXqPypU01ve2QVdbhuSo6+hULw5bavkDJ LKg3MOVrXTk2Z+X9MINHaoZco2OH6FYHLr42Kqkg= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E688F3858405 for ; Sat, 11 Dec 2021 00:21:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E688F3858405 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1BB0L4h3025372 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Dec 2021 19:21:09 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1BB0L4h3025372 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 79E7B1EDEE; Fri, 10 Dec 2021 19:21:03 -0500 (EST) Message-ID: <094fd87c-0e22-b874-a661-05759b20c696@polymtl.ca> Date: Fri, 10 Dec 2021 19:21:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2] gdb fix for catch-syscall.exp Content-Language: en-US To: Carl Love , Simon Marchi , John Baldwin , gdb-patches@sourceware.org References: <3b8e450b9fb4f4bec97a6bfbe6e6a4816be780ee.camel@us.ibm.com> <4d51616392553dd308672f65f18909ebf0513fc0.camel@us.ibm.com> <95fbffc3-8d30-6e75-4f52-f6e534a13b20@FreeBSD.org> <8269783078cecf5fe7fb7bea8d546256aafc7071.camel@us.ibm.com> <5f745078-cb28-86ae-1edd-bff0333283b6@simark.ca> <5644a7484e2b2024166cd7a7d091d11052f96cc6.camel@us.ibm.com> In-Reply-To: <5644a7484e2b2024166cd7a7d091d11052f96cc6.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 11 Dec 2021 00:21:04 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Rogerio Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp > > Powerpc is not reporting the > > Catchpoint 1 (returned from syscall execve), .... > > as expected. The issue appears to be with the kernel not returning the > expected result. This patch marks the test failure as an xfail. > > See gdb bugzilla https://sourceware.org/bugzilla/show_bug.cgi?id=28623 When we got rid of ChangeLogs, we agreed on the format: Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28623 when referring to bugzilla entries, let's use that. > --- > gdb/testsuite/gdb.base/catch-syscall.exp | 38 ++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 6 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp b/gdb/testsuite/gdb.base/catch-syscall.exp > index cdd5e2aec47..76c5cfbc6d6 100644 > --- a/gdb/testsuite/gdb.base/catch-syscall.exp > +++ b/gdb/testsuite/gdb.base/catch-syscall.exp > @@ -127,7 +127,29 @@ proc check_return_from_syscall { syscall { pattern "" } } { > } > > set thistest "syscall $syscall has returned" > - gdb_test "continue" "Catchpoint $decimal \\(returned from syscall ${pattern}\\).*" $thistest > + if { $pattern eq "execve" } { > + gdb_test_multiple "continue" $thistest { > + -re -wrap "Catchpoint $decimal \\(returned from syscall ${pattern}\\).*" { > + pass $thistest > + return 1 > + } > + -re -wrap ".*Breakpoint $decimal, main .*" { > + # On Powerpc kernel does not report the returned from syscall kernel -> the kernel returned -> return > + # as expected by the test. GDB bugzilla 28623. > + puts "CARLL test failed" Leftover print. Ok with those fixed. Simon