New ARI warning Wed Feb 16 01:53:55 UTC 2011

New ARI warning Wed Feb 16 01:53:55 UTC 2011

[GDB Administrator]

1103a1104
> gdb/thread.c:983: gettext: _ markup: All messages should be marked up with _.
gdb/thread.c:983:	error ("invalid thread id %d\n", tmp_tid);

Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

On 02/16/2011 09:53 AM, GDB Administrator wrote:
> 1103a1104
>> gdb/thread.c:983: gettext: _ markup: All messages should be marked up with _.
> gdb/thread.c:983:	error ("invalid thread id %d\n", tmp_tid);

This patch is obvious, and I'll apply it later today.

-- 
Yao (齐尧)

[-- Attachment #2: ari_thread.patch --]
[-- Type: text/x-patch, Size: 615 bytes --]

2011-02-16  Yao Qi  <yao@codesourcery.com>

	* thread.c (info_threads_command): Add missing i18n markup.

Index: gdb/thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.132
diff -u -r1.132 thread.c
--- gdb/thread.c	15 Feb 2011 21:17:52 -0000	1.132
+++ gdb/thread.c	16 Feb 2011 05:19:32 -0000
@@ -980,7 +980,7 @@
       unsigned int highrange;
 
       if (tmp_tid <= 0)
-	error ("invalid thread id %d\n", tmp_tid);
+	error (_("invalid thread id %d\n"), tmp_tid);
 
       tid = tmp_tid;
       print_thread_info (uiout, tid, -1);

RE: New ARI warning Wed Feb 16 01:53:55 UTC 2011

[Pierre Muller]

Hi Yao,

  could you please modify this patch
so as to also remove the trailing newline?

Index: gdb/thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.132
diff -u -r1.132 thread.c
--- gdb/thread.c	15 Feb 2011 21:17:52 -0000	1.132
+++ gdb/thread.c	16 Feb 2011 05:19:32 -0000
@@ -980,7 +980,7 @@
       unsigned int highrange;
 
       if (tmp_tid <= 0)
-	error ("invalid thread id %d\n", tmp_tid);
+	error (_("invalid thread id %d"), tmp_tid);
 
       tid = tmp_tid;
       print_thread_info (uiout, tid, -1);

  This is one of the other ARI rules:
"A message should not have a trailing new line"

  It did not show up yet, because the markup rule
is just before in the gdb_ari.sh script.

Thanks in advance,

Pierre Muller
as "ARI maintainer"...


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Yao Qi
> Envoyé : mercredi 16 février 2011 06:35
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011
> 
> On 02/16/2011 09:53 AM, GDB Administrator wrote:
> > 1103a1104
> >> gdb/thread.c:983: gettext: _ markup: All messages should be marked
> up with _.
> > gdb/thread.c:983:	error ("invalid thread id %d\n", tmp_tid);
> 
> This patch is obvious, and I'll apply it later today.
> 
> --
> Yao (齐尧)

Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011

[Yao Qi]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

On 02/16/2011 04:38 PM, Pierre Muller wrote:
> Hi Yao,
> 
>   could you please modify this patch
> so as to also remove the trailing newline?

Sure.  Applied.

-- 
Yao (齐尧)

[-- Attachment #2: ari_thread.patch --]
[-- Type: text/x-patch, Size: 1050 bytes --]

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.12591
diff -u -r1.12591 ChangeLog
--- gdb/ChangeLog	15 Feb 2011 21:43:24 -0000	1.12591
+++ gdb/ChangeLog	16 Feb 2011 09:45:02 -0000
@@ -1,3 +1,8 @@
+2011-02-16  Yao Qi  <yao@codesourcery.com>
+
+	* thread.c (info_threads_command): Add missing i18n markup and remove
+	trailing newline.
+
 2011-02-15  Paul Pluzhnikov  <ppluzhnikov@google.com>
 
 	* breakpoint.c (longjmp_names): New variable.
Index: gdb/thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.132
diff -u -r1.132 thread.c
--- gdb/thread.c	15 Feb 2011 21:17:52 -0000	1.132
+++ gdb/thread.c	16 Feb 2011 09:45:02 -0000
@@ -980,7 +980,7 @@
       unsigned int highrange;
 
       if (tmp_tid <= 0)
-	error ("invalid thread id %d\n", tmp_tid);
+	error (_("invalid thread id %d"), tmp_tid);
 
       tid = tmp_tid;
       print_thread_info (uiout, tid, -1);

Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011

[Michael Snyder]

Yao Qi wrote:
> On 02/16/2011 09:53 AM, GDB Administrator wrote:
>> 1103a1104
>>> gdb/thread.c:983: gettext: _ markup: All messages should be marked up with _.
>> gdb/thread.c:983:	error ("invalid thread id %d\n", tmp_tid);
> 
> This patch is obvious, and I'll apply it later today.
> 

Thank you.  Sorry about it...