RE: New ARI warning Wed Feb 16 01:53:55 UTC 2011

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

Hi Yao,

  could you please modify this patch
so as to also remove the trailing newline?

Index: gdb/thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.132
diff -u -r1.132 thread.c
--- gdb/thread.c	15 Feb 2011 21:17:52 -0000	1.132
+++ gdb/thread.c	16 Feb 2011 05:19:32 -0000
@@ -980,7 +980,7 @@
       unsigned int highrange;
 
       if (tmp_tid <= 0)
-	error ("invalid thread id %d\n", tmp_tid);
+	error (_("invalid thread id %d"), tmp_tid);
 
       tid = tmp_tid;
       print_thread_info (uiout, tid, -1);

  This is one of the other ARI rules:
"A message should not have a trailing new line"

  It did not show up yet, because the markup rule
is just before in the gdb_ari.sh script.

Thanks in advance,

Pierre Muller
as "ARI maintainer"...


> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Yao Qi
> Envoyé : mercredi 16 février 2011 06:35
> À : gdb-patches@sourceware.org
> Objet : Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011
> 
> On 02/16/2011 09:53 AM, GDB Administrator wrote:
> > 1103a1104
> >> gdb/thread.c:983: gettext: _ markup: All messages should be marked
> up with _.
> > gdb/thread.c:983:	error ("invalid thread id %d\n", tmp_tid);
> 
> This patch is obvious, and I'll apply it later today.
> 
> --
> Yao (齐尧)