From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25909 invoked by alias); 16 Feb 2011 08:38:51 -0000 Received: (qmail 25899 invoked by uid 22791); 16 Feb 2011 08:38:50 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 08:38:44 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p1G8cbbr096336 ; Wed, 16 Feb 2011 09:38:37 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [130.79.204.10]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1G8caOv099678 ; Wed, 16 Feb 2011 09:38:36 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p1G8cZrY065357 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Wed, 16 Feb 2011 09:38:36 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Yao Qi'" , References: <20110216015355.GA13284@sourceware.org> <4D5B61F0.1030502@codesourcery.com> In-Reply-To: <4D5B61F0.1030502@codesourcery.com> Subject: RE: New ARI warning Wed Feb 16 01:53:55 UTC 2011 Date: Wed, 16 Feb 2011 09:29:00 -0000 Message-ID: <006601cbcdb4$e8381cf0$b8a856d0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00354.txt.bz2 Hi Yao, could you please modify this patch so as to also remove the trailing newline? Index: gdb/thread.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/thread.c,v retrieving revision 1.132 diff -u -r1.132 thread.c --- gdb/thread.c 15 Feb 2011 21:17:52 -0000 1.132 +++ gdb/thread.c 16 Feb 2011 05:19:32 -0000 @@ -980,7 +980,7 @@ unsigned int highrange; =20 if (tmp_tid <=3D 0) - error ("invalid thread id %d\n", tmp_tid); + error (_("invalid thread id %d"), tmp_tid); =20 tid =3D tmp_tid; print_thread_info (uiout, tid, -1); This is one of the other ARI rules: "A message should not have a trailing new line" It did not show up yet, because the markup rule is just before in the gdb_ari.sh script. Thanks in advance, Pierre Muller as "ARI maintainer"... > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Yao Qi > Envoy=C3=A9 : mercredi 16 f=C3=A9vrier 2011 06:35 > =C3=80 : gdb-patches@sourceware.org > Objet : Re: New ARI warning Wed Feb 16 01:53:55 UTC 2011 >=20 > On 02/16/2011 09:53 AM, GDB Administrator wrote: > > 1103a1104 > >> gdb/thread.c:983: gettext: _ markup: All messages should be marked > up with _. > > gdb/thread.c:983: error ("invalid thread id %d\n", tmp_tid); >=20 > This patch is obvious, and I'll apply it later today. >=20 > -- > Yao (=E9=BD=90=E5=B0=A7)