From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] Use winsock2 for mingw gdbserver
Date: Sat, 17 Apr 2010 20:44:00 -0000 [thread overview]
Message-ID: <003401cade6e$bfdef7f0$3f9ce7d0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <201004170927.53523.pedro@codesourcery.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : Saturday, April 17, 2010 10:28 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] Use winsock2 for mingw gdbserver
>
> On Saturday 17 April 2010 06:39:45, Pierre Muller wrote:
>
> >
> > Here you are:
> > is this OK?
> > Once again, its the formatting of the
> > ChangeLog that seems the most uncertain to me...
>
> It's fine, although "Include winsock2.h instead of winsock.h" would be
> more straight to the point... (doesn't need to answer the question:
> "and what is the winsock2 header in the first place? ws2.h? other?")
>
> When in doubt, start by looking at previous entries. There are several
> `* file.c (foo): Include bar.h.', but none `* file.c (foo): Include bar
> header.'
>
> > 2010-04-17 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > * configure.ac: Use `ws2_32' library for srv_mingw.
> > * configure: Regenerate.
> > * gdbreplay.c: Use winsock2 header instead of winsock for mingw.
> > * remote-utils.c: Likewise.
>
> This is okay.
Thanks, committed now, with a changed ChangeLog as you suggested above.
Pierre
next prev parent reply other threads:[~2010-04-17 20:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 15:32 [RFC] Mingw Windows 64-bit gdbserver Pierre Muller
2010-04-16 15:59 ` Pedro Alves
2010-04-16 16:20 ` Pierre Muller
2010-04-16 16:27 ` Pedro Alves
2010-04-16 16:38 ` Pierre Muller
2010-04-16 17:15 ` Pedro Alves
2010-04-17 5:39 ` [RFA] Use winsock2 for mingw gdbserver Pierre Muller
2010-04-17 8:28 ` Pedro Alves
2010-04-17 20:44 ` Pierre Muller [this message]
2010-04-17 5:40 ` [RFC] Mingw Windows 64-bit gdbserver Pierre Muller
2010-04-17 10:58 ` Pedro Alves
2010-04-17 23:18 ` [RFC-v2] " Pierre Muller
2010-04-17 23:46 ` Pedro Alves
2010-04-19 6:37 ` [RFA] Prepare for " Pierre Muller
[not found] ` <6200558430975530197@unknownmsgid>
2010-04-19 13:56 ` H.J. Lu
2010-04-19 14:13 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003401cade6e$bfdef7f0$3f9ce7d0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox