From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <hjl@sourceware.org>
Cc: "'Pedro Alves'" <pedro@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: [RFA] Prepare for Mingw Windows 64-bit gdbserver
Date: Mon, 19 Apr 2010 06:37:00 -0000 [thread overview]
Message-ID: <003301cadf8a$ca5046e0$5ef0d4a0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <201004180045.51495.pedro@codesourcery.com>
> > -srv_amd64_regobj="amd64.o x86-64-avx.o"
> > +srv_amd64_regobj="amd64.o amd64-avx.o"
>
> looks like another piece. Is it just a cosmetic change because
> we use amd64 instead of x86-64 throughout? Please explain
> it and post it separately, if possible.
I suspect that this is an error in the commit
from H.J. Lu dated 2010/04/07.
The ChangeLog says:
* configure.srv (srv_i386_regobj): Add i386-avx.o.
(srv_i386_linux_regobj): Add i386-avx-linux.o.
(srv_amd64_regobj): Add amd64-avx.o.
But
$ cvs diff -r 1.51 -r 1.52 configure.srv
Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.51
retrieving revision 1.52
diff -r1.51 -r1.52
25,28c25,28
< srv_i386_regobj=i386.o
< srv_i386_linux_regobj=i386-linux.o
< srv_amd64_regobj=amd64.o
< srv_amd64_linux_regobj=amd64-linux.o
---
> srv_i386_regobj="i386.o i386-avx.o"
> srv_i386_linux_regobj="i386-linux.o i386-avx-linux.o"
> srv_amd64_regobj="amd64.o x86-64-avx.o"
> srv_amd64_linux_regobj="amd64-linux.o amd64-avx-linux.o"
30,35c30,35
As srv_amd64_regobj is not yet used, nobody noticed it before
I tried to use it for mingw64 support.
Is this OK?
Pierre
PS: I will try to send the patch into several sub-patches,
but I am still not used to handling patch series ...
ChangeLog entry:
2010-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
* configure.srv (srv_amd64_regobj): Replace `x86-64-avx.o' by
`amd64-avx.o'.
Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.53
diff -u -p -r1.53 configure.srv
--- configure.srv 8 Apr 2010 22:32:38 -0000 1.53
+++ configure.srv 18 Apr 2010 15:34:29 -0000
@@ -24,7 +24,7 @@ srv_hostio_err_objs="hostio-errno.o"
srv_i386_regobj="i386.o i386-avx.o i386-mmx.o"
srv_i386_linux_regobj="i386-linux.o i386-avx-linux.o i386-mmx-linux.o"
-srv_amd64_regobj="amd64.o x86-64-avx.o"
+srv_amd64_regobj="amd64.o amd64-avx.o"
srv_amd64_linux_regobj="amd64-linux.o amd64-avx-linux.o"
srv_i386_32bit_xmlfiles="i386/32bit-core.xml i386/32bit-sse.xml
i386/32bit-avx.xml"
next prev parent reply other threads:[~2010-04-19 6:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 15:32 [RFC] " Pierre Muller
2010-04-16 15:59 ` Pedro Alves
2010-04-16 16:20 ` Pierre Muller
2010-04-16 16:27 ` Pedro Alves
2010-04-16 16:38 ` Pierre Muller
2010-04-16 17:15 ` Pedro Alves
2010-04-17 5:39 ` [RFA] Use winsock2 for mingw gdbserver Pierre Muller
2010-04-17 8:28 ` Pedro Alves
2010-04-17 20:44 ` Pierre Muller
2010-04-17 5:40 ` [RFC] Mingw Windows 64-bit gdbserver Pierre Muller
2010-04-17 10:58 ` Pedro Alves
2010-04-17 23:18 ` [RFC-v2] " Pierre Muller
2010-04-17 23:46 ` Pedro Alves
2010-04-19 6:37 ` Pierre Muller [this message]
[not found] ` <6200558430975530197@unknownmsgid>
2010-04-19 13:56 ` [RFA] Prepare for " H.J. Lu
2010-04-19 14:13 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003301cadf8a$ca5046e0$5ef0d4a0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=hjl@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox