From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 313 invoked by alias); 17 Apr 2010 20:44:21 -0000 Received: (qmail 301 invoked by uid 22791); 17 Apr 2010 20:44:20 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Apr 2010 20:44:15 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3HKi88F016657 ; Sat, 17 Apr 2010 22:44:08 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3HKi50C077212 ; Sat, 17 Apr 2010 22:44:08 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3HKi4rw016615 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Sat, 17 Apr 2010 22:44:05 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: References: <000d01cadd79$efa9e2b0$cefda810$@muller@ics-cnrs.unistra.fr> <201004161815.36864.pedro@codesourcery.com> <001c01caddf0$63952a10$2abf7e30$@muller@ics-cnrs.unistra.fr> <201004170927.53523.pedro@codesourcery.com> In-Reply-To: <201004170927.53523.pedro@codesourcery.com> Subject: RE: [RFA] Use winsock2 for mingw gdbserver Date: Sat, 17 Apr 2010 20:44:00 -0000 Message-ID: <003401cade6e$bfdef7f0$3f9ce7d0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00536.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Saturday, April 17, 2010 10:28 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Use winsock2 for mingw gdbserver >=20 > On Saturday 17 April 2010 06:39:45, Pierre Muller wrote: >=20 > > > > Here you are: > > is this OK? > > Once again, it=92s the formatting of the > > ChangeLog that seems the most uncertain to me... >=20 > It's fine, although "Include winsock2.h instead of winsock.h" would be > more straight to the point... (doesn't need to answer the question: > "and what is the winsock2 header in the first place? ws2.h? other?") >=20 > When in doubt, start by looking at previous entries. There are several > `* file.c (foo): Include bar.h.', but none `* file.c (foo): Include bar > header.' >=20 > > 2010-04-17 Pierre Muller > > > > * configure.ac: Use `ws2_32' library for srv_mingw. > > * configure: Regenerate. > > * gdbreplay.c: Use winsock2 header instead of winsock for mingw. > > * remote-utils.c: Likewise. >=20 > This is okay. Thanks, committed now, with a changed ChangeLog as you suggested above. Pierre