Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Richard Earnshaw'" <rearnsha@arm.com>
Cc: "'Daniel Jacobowitz'" <dan@codesourcery.com>,
	       "'Ulrich Weigand'" <uweigand@de.ibm.com>,
	<gdb-patches@sourceware.org>
Subject: [RFA] About arm-tdep.c arm_in_function_epilogue_p function
Date: Thu, 18 Nov 2010 13:43:00 -0000	[thread overview]
Message-ID: <002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <1290086858.18751.21.camel@e102346-lin.cambridge.arm.com>

  OK, here is the patch.

  As already said, this patch doesn't change anything on
the testsuite results for a armv7l linux machine.

> Why don't you just post a patch?  Then we can assess it as we would all
> other patches.  The comments in the code at this point clearly don't
> match the code, so something certainly needs fixing.
> 
> R.

OK to apply?

2010-11-18  Pierre Muller  <muller@ics.u-strasbg.fr>

        * arm-tdep.c (arm_in_function_epilogue_p): Fix code when "MOV SP"
        instruction is found.

Index: src/gdb/arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.312
diff -u -p -r1.312 arm-tdep.c
--- src/14 Nov 2010 12:10:59 -0000      1.312
+++ src/gdb/arm-tdep.c  18 Nov 2010 13:35:41 -0000
@@ -2245,7 +2245,7 @@ arm_in_function_epilogue_p (struct gdbar
        found_stack_adjust = 1;
       else if ((insn & 0x0ffffff0) == 0x01a0d000)
        /* MOV SP.  */
-       found_return = 1;
+       found_stack_adjust = 1;
       else if ((insn & 0x0fff0000) == 0x08bd0000)
        /* POP (LDMIA).  */
        found_stack_adjust = 1;


  reply	other threads:[~2010-11-18 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 12:19 [RFC] " Pierre Muller
2010-11-16  0:04 ` Daniel Jacobowitz
2010-11-18 11:07   ` Pierre Muller
2010-11-18 13:27     ` Richard Earnshaw
2010-11-18 13:43       ` Pierre Muller [this message]
2010-11-18 13:56         ` [RFA] " Richard Earnshaw
2010-11-19  8:10           ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=rearnsha@arm.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox