Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Daniel Jacobowitz'" <dan@codesourcery.com>
Cc: "'Ulrich Weigand'" <uweigand@de.ibm.com>, <gdb-patches@sourceware.org>
Subject: RE: [RFC] About arm-tdep.c arm_in_function_epilogue_p function
Date: Thu, 18 Nov 2010 11:07:00 -0000	[thread overview]
Message-ID: <000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20101116000346.GN8573@caradoc.them.org>

Hi,


On Sun, Nov 14, 2010 at 01:19:29PM +0100, Pierre Muller wrote:
> >>> Furthermore, found_return isn't used
> >>> anymore in that function.
> >>> Isn't the correct code
> >>>     found_stack_adjust = 1;

> I'm pretty sure you're right.  I'm not set up at the moment to test
> patches on ARM, but if anyone reading this is, then I'd approve
> that change.

  I was able to compile and run the testsuite on an arm linux
machine, processor type armv7l.
  Unfortunately, the testsuite seems to never trigger this instruction.
(Checked by adding some specific output if the code triggers,
not found in gdb.log after testsuite completion.)
  So I think we should rather leave the decision to Ulrich,
as he seems much more involved in the arm target, no?


Pierre Muller
GDB pascal language maintainer




  reply	other threads:[~2010-11-18 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 12:19 Pierre Muller
2010-11-16  0:04 ` Daniel Jacobowitz
2010-11-18 11:07   ` Pierre Muller [this message]
2010-11-18 13:27     ` Richard Earnshaw
2010-11-18 13:43       ` [RFA] " Pierre Muller
2010-11-18 13:56         ` Richard Earnshaw
2010-11-19  8:10           ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox