From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28440 invoked by alias); 18 Nov 2010 11:07:23 -0000 Received: (qmail 28431 invoked by uid 22791); 18 Nov 2010 11:07:23 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_40,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 11:07:15 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id oAIB771R025307 ; Thu, 18 Nov 2010 12:07:07 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [130.79.204.11]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAIB770C070590 ; Thu, 18 Nov 2010 12:07:07 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAIB76IZ049347 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Thu, 18 Nov 2010 12:07:06 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Daniel Jacobowitz'" Cc: "'Ulrich Weigand'" , References: <002701cb83f6$30b394e0$921abea0$@muller@ics-cnrs.unistra.fr> <20101116000346.GN8573@caradoc.them.org> In-Reply-To: <20101116000346.GN8573@caradoc.them.org> Subject: RE: [RFC] About arm-tdep.c arm_in_function_epilogue_p function Date: Thu, 18 Nov 2010 11:07:00 -0000 Message-ID: <000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00230.txt.bz2 Hi, On Sun, Nov 14, 2010 at 01:19:29PM +0100, Pierre Muller wrote: > >>> Furthermore, found_return isn't used > >>> anymore in that function. > >>> Isn't the correct code > >>> found_stack_adjust = 1; > I'm pretty sure you're right. I'm not set up at the moment to test > patches on ARM, but if anyone reading this is, then I'd approve > that change. I was able to compile and run the testsuite on an arm linux machine, processor type armv7l. Unfortunately, the testsuite seems to never trigger this instruction. (Checked by adding some specific output if the code triggers, not found in gdb.log after testsuite completion.) So I think we should rather leave the decision to Ulrich, as he seems much more involved in the arm target, no? Pierre Muller GDB pascal language maintainer