From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76475-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12108 invoked by alias); 18 Nov 2010 13:43:32 -0000
Received: (qmail 12091 invoked by uid 22791); 18 Nov 2010 13:43:32 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 13:43:26 +0000
Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id oAIDhEUs048618           ; Thu, 18 Nov 2010 14:43:14 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [130.79.204.12])           by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAIDhDXL085345           ; Thu, 18 Nov 2010 14:43:13 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id oAIDhCL7005089 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Thu, 18 Nov 2010 14:43:13 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Richard Earnshaw'" <rearnsha@arm.com>
Cc: "'Daniel Jacobowitz'" <dan@codesourcery.com>,        "'Ulrich Weigand'" <uweigand@de.ibm.com>, <gdb-patches@sourceware.org>
References: <002701cb83f6$30b394e0$921abea0$@muller@ics-cnrs.unistra.fr>	 <20101116000346.GN8573@caradoc.them.org>	 <000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr> <1290086858.18751.21.camel@e102346-lin.cambridge.arm.com>
In-Reply-To: <1290086858.18751.21.camel@e102346-lin.cambridge.arm.com>
Subject: [RFA] About arm-tdep.c arm_in_function_epilogue_p function
Date: Thu, 18 Nov 2010 13:43:00 -0000
Message-ID: <002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00232.txt.bz2

  OK, here is the patch.

  As already said, this patch doesn't change anything on
the testsuite results for a armv7l linux machine.

> Why don't you just post a patch?  Then we can assess it as we would all
> other patches.  The comments in the code at this point clearly don't
> match the code, so something certainly needs fixing.
> 
> R.

OK to apply?

2010-11-18  Pierre Muller  <muller@ics.u-strasbg.fr>

        * arm-tdep.c (arm_in_function_epilogue_p): Fix code when "MOV SP"
        instruction is found.

Index: src/gdb/arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.312
diff -u -p -r1.312 arm-tdep.c
--- src/14 Nov 2010 12:10:59 -0000      1.312
+++ src/gdb/arm-tdep.c  18 Nov 2010 13:35:41 -0000
@@ -2245,7 +2245,7 @@ arm_in_function_epilogue_p (struct gdbar
        found_stack_adjust = 1;
       else if ((insn & 0x0ffffff0) == 0x01a0d000)
        /* MOV SP.  */
-       found_return = 1;
+       found_stack_adjust = 1;
       else if ((insn & 0x0fff0000) == 0x08bd0000)
        /* POP (LDMIA).  */
        found_stack_adjust = 1;