New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15

New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15

[GDB Administrator]

11a12
> gdb/aix-thread.c:263: code: long long: Do not use 'long long', instead use LONGEST
gdb/aix-thread.c:263:# define addr_ptr long long
15a17
> gdb/aix-thread.c:1017: code: long long: Do not use 'long long', instead use LONGEST
gdb/aix-thread.c:1017:	ptrace64aix (PTT_CONTINUE, tid[0], (long long) 1,
198a201,202
> gdb/dwarf2read.c:7003: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/dwarf2read.c:7003:	      sprintf (buf, ',
> gdb/dwarf2read.c:7007: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/dwarf2read.c:7007:	    sprintf (buf, ', per_cu->offset.sect_off);
204d207
< gdb/exceptions.c:238: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/exceptions.c:238:deprecated_throw_reason (enum return_reason reason)
207d209
< gdb/exceptions.h:191: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/exceptions.h:191:extern void deprecated_throw_reason (enum return_reason reason)
226a229
> gdb/gdb_ptrace.h:142: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdb_ptrace.h:142:#  define PTRACE_TYPE_ARG3 long long
416d418
< gdb/mi/mi-main.c:1595: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/mi/mi-main.c:1595:	  sprintf (p, ', read_result->data[i]);
417a420
> gdb/mi/mi-main.c:2845: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/mi/mi-main.c:2845:		  sprintf (p, ', data[m]);
438d440
< gdb/monitor.c:1039: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/monitor.c:1039:      deprecated_throw_reason (RETURN_QUIT);
453a456
> gdb/msp430-tdep.c:552: code: OP eol: Do not use &&, or || at the end of a line
gdb/msp430-tdep.c:552:						  frame_base +
466d468
< gdb/nto-procfs.c:697: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/nto-procfs.c:697:      deprecated_throw_reason (RETURN_QUIT);
568d569
< gdb/remote-fileio.c:516: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/remote-fileio.c:516:  deprecated_throw_reason (RETURN_QUIT);
573d573
< gdb/remote-mips.c:513: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/remote-mips.c:513:  deprecated_throw_reason (RETURN_ERROR);
579d578
< gdb/remote-mips.c:2297: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/remote-mips.c:2297:	  deprecated_throw_reason (RETURN_QUIT);
613,614d611
< gdb/remote.c:5165: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/remote.c:5165:      deprecated_throw_reason (RETURN_QUIT);
< gdb/remote.c:5173: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/remote.c:5173:	  deprecated_throw_reason (RETURN_QUIT);
623a621,624
> gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:134:  #ifdef HAVE_PTRACE64
> gdb/rs6000-nat.c:135: code: long long: Do not use 'long long', instead use LONGEST
gdb/rs6000-nat.c:135:  int ret = ptrace64 (req, id, (long long) addr, data, buf);
> gdb/rs6000-nat.c:136: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:136:  #else
> gdb/rs6000-nat.c:138: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:138:  #endif
624a626,628
> gdb/rs6000-nat.c:152: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:152:  #ifdef HAVE_PTRACE64
> gdb/rs6000-nat.c:154: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:154:  #else
> gdb/rs6000-nat.c:156: regression: hash: Do not use ' #...', instead use '#...'(some compilers only correctly parse a C preprocessor directive when '#' is the first character on the line)
gdb/rs6000-nat.c:156:  #endif
775,777d778
< gdb/tracepoint.c:90: deprecated: deprecated readline_begin_hook: Do not use deprecated readline_begin_hook, see declaration for details
gdb/tracepoint.c:90:extern void (*deprecated_readline_begin_hook) (char *, ...);
< gdb/tracepoint.c:91: deprecated: deprecated readline_hook: Do not use deprecated readline_hook, see declaration for details
gdb/tracepoint.c:91:extern char *(*deprecated_readline_hook) (char *);
< gdb/tracepoint.c:92: deprecated: deprecated readline_end_hook: Do not use deprecated readline_end_hook, see declaration for details
gdb/tracepoint.c:92:extern void (*deprecated_readline_end_hook) (void);
834d834
< gdb/utils.c:836: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details
gdb/utils.c:836:  deprecated_throw_reason (RETURN_ERROR);

RE: New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15

[Pierre Muller]

  This is indeed great news:
it means that Joel succeeded in fixing the nightly snapshot
and ARI update!

  Thanks, Joel!

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de GDB Administrator
> Envoyé : dimanche 18 août 2013 03:52
> À : gdb-patches@sourceware.org
> Objet : New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D
> 2013.08.18.00.00.15
> > gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead use
> '#...'(some compilers only correctly parse a C preprocessor directive when
> '#' is the first character on the line)
> gdb/rs6000-nat.c:134:  #ifdef HAVE_PTRACE64

  In rs6000-nat.c, a new regression was introduced
related to the hash rule:

This rule says that:
Do not use ` #...', instead use `#...'(some compilers only correctly parse a
C preprocessor directive when `#' is the first character on the line)

Pierre Muller
as ARI maintainer

Re: New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15

[Joel Brobecker]

>   This is indeed great news:
> it means that Joel succeeded in fixing the nightly snapshot
> and ARI update!

Unfortunately, not everything works yet, and I might not have the time
today to look into it :-(.

-- 
Joel

[OBV commit] Fix New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15

[Pierre Muller]

> > Objet : New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D
> > 2013.08.18.00.00.15
> > > gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead
use
> > '#...'(some compilers only correctly parse a C preprocessor directive
when
> > '#' is the first character on the line)
> > gdb/rs6000-nat.c:134:  #ifdef HAVE_PTRACE64
> 
>   In rs6000-nat.c, a new regression was introduced
> related to the hash rule:
> 
> This rule says that:
> Do not use ` #...', instead use `#...'(some compilers only correctly parse
a
> C preprocessor directive when `#' is the first character on the line)
 

Fix committed as obvious,

Pierre Muller
as ARI maintainer

2013-08-23  Pierre Muller  <muller@sourceware.org>

	ARI fix: Push # directives to start of line.
	* rs6000-nat.c (rs6000_ptrace32, rs6000_ptrace64): Rule applied.

Index: rs6000-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-nat.c,v
retrieving revision 1.129
diff -u -p -r1.129 rs6000-nat.c
--- rs6000-nat.c	7 Aug 2013 14:39:57 -0000	1.129
+++ rs6000-nat.c	23 Aug 2013 06:46:18 -0000
@@ -131,11 +131,11 @@ regmap (struct gdbarch *gdbarch, int reg
 static int
 rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf)
 {
-  #ifdef HAVE_PTRACE64
+#ifdef HAVE_PTRACE64
   int ret = ptrace64 (req, id, (long long) addr, data, buf);
-  #else
+#else
   int ret = ptrace (req, id, (int *)addr, data, buf);
-  #endif
+#endif
 #if 0
   printf ("rs6000_ptrace32 (%d, %d, 0x%x, %08x, 0x%x) = 0x%x\n",
 	  req, id, (unsigned int)addr, data, (unsigned int)buf, ret);
@@ -149,11 +149,11 @@ static int
 rs6000_ptrace64 (int req, int id, long long addr, int data, void *buf)
 {
 #ifdef ARCH3264
-  #ifdef HAVE_PTRACE64
+#  ifdef HAVE_PTRACE64
   int ret = ptrace64 (req, id, addr, data, buf);
-  #else
+#  else
   int ret = ptracex (req, id, addr, data, buf);
-  #endif
+#  endif
 #else
   int ret = 0;
 #endif