From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14204 invoked by alias); 23 Aug 2013 06:55:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14191 invoked by uid 89); 23 Aug 2013 06:55:18 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 Received: from mailhost.u-strasbg.fr (HELO mr2.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 06:55:15 +0000 Received: from mr2.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id B051466C for ; Fri, 23 Aug 2013 08:55:11 +0200 (CEST) Received: from mr2.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 48CBD726 for ; Fri, 23 Aug 2013 08:54:45 +0200 (CEST) Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mr2.u-strasbg.fr (Postfix) with ESMTP id 39A12730 for ; Fri, 23 Aug 2013 08:54:44 +0200 (CEST) Received: from ms17.u-strasbg.fr (ms17.u-strasbg.fr [130.79.204.117]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r7N6shE4015857 ; Fri, 23 Aug 2013 08:54:44 +0200 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms17.u-strasbg.fr (Postfix) with ESMTPSA id D92D61FD95; Fri, 23 Aug 2013 08:54:42 +0200 (CEST) From: "Pierre Muller" To: "'Pierre Muller'" , References: <20130818015149.GA4386@sourceware.org> <000301ce9c04$0c81abb0$25850310$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000301ce9c04$0c81abb0$25850310$@muller@ics-cnrs.unistra.fr> Subject: [OBV commit] Fix New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15 Date: Fri, 23 Aug 2013 06:55:00 -0000 Message-ID: <001201ce9fcd$a31b7200$e9525600$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00664.txt.bz2 > > Objet=A0: New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D > > 2013.08.18.00.00.15 > > > gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead use > > '#...'(some compilers only correctly parse a C preprocessor directive when > > '#' is the first character on the line) > > gdb/rs6000-nat.c:134: #ifdef HAVE_PTRACE64 >=20 > In rs6000-nat.c, a new regression was introduced > related to the hash rule: >=20 > This rule says that: > Do not use ` #...', instead use `#...'(some compilers only correctly parse a > C preprocessor directive when `#' is the first character on the line) =20 Fix committed as obvious, Pierre Muller as ARI maintainer 2013-08-23 Pierre Muller ARI fix: Push # directives to start of line. * rs6000-nat.c (rs6000_ptrace32, rs6000_ptrace64): Rule applied. Index: rs6000-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/rs6000-nat.c,v retrieving revision 1.129 diff -u -p -r1.129 rs6000-nat.c --- rs6000-nat.c 7 Aug 2013 14:39:57 -0000 1.129 +++ rs6000-nat.c 23 Aug 2013 06:46:18 -0000 @@ -131,11 +131,11 @@ regmap (struct gdbarch *gdbarch, int reg static int rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf) { - #ifdef HAVE_PTRACE64 +#ifdef HAVE_PTRACE64 int ret =3D ptrace64 (req, id, (long long) addr, data, buf); - #else +#else int ret =3D ptrace (req, id, (int *)addr, data, buf); - #endif +#endif #if 0 printf ("rs6000_ptrace32 (%d, %d, 0x%x, %08x, 0x%x) =3D 0x%x\n", req, id, (unsigned int)addr, data, (unsigned int)buf, ret); @@ -149,11 +149,11 @@ static int rs6000_ptrace64 (int req, int id, long long addr, int data, void *buf) { #ifdef ARCH3264 - #ifdef HAVE_PTRACE64 +# ifdef HAVE_PTRACE64 int ret =3D ptrace64 (req, id, addr, data, buf); - #else +# else int ret =3D ptracex (req, id, addr, data, buf); - #endif +# endif #else int ret =3D 0; #endif