Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pierre Muller'" <pierre.muller@ics-cnrs.unistra.fr>,
	       <gdb-patches@sourceware.org>
Subject: [OBV commit] Fix New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D 2013.08.18.00.00.15
Date: Fri, 23 Aug 2013 06:55:00 -0000	[thread overview]
Message-ID: <001201ce9fcd$a31b7200$e9525600$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <000301ce9c04$0c81abb0$25850310$@muller@ics-cnrs.unistra.fr>

> > Objet : New ARI warning Sun Aug 18 01:51:49 UTC 2013 in -D
> > 2013.08.18.00.00.15
> > > gdb/rs6000-nat.c:134: regression: hash: Do not use ' #...', instead
use
> > '#...'(some compilers only correctly parse a C preprocessor directive
when
> > '#' is the first character on the line)
> > gdb/rs6000-nat.c:134:  #ifdef HAVE_PTRACE64
> 
>   In rs6000-nat.c, a new regression was introduced
> related to the hash rule:
> 
> This rule says that:
> Do not use ` #...', instead use `#...'(some compilers only correctly parse
a
> C preprocessor directive when `#' is the first character on the line)
 

Fix committed as obvious,

Pierre Muller
as ARI maintainer

2013-08-23  Pierre Muller  <muller@sourceware.org>

	ARI fix: Push # directives to start of line.
	* rs6000-nat.c (rs6000_ptrace32, rs6000_ptrace64): Rule applied.

Index: rs6000-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-nat.c,v
retrieving revision 1.129
diff -u -p -r1.129 rs6000-nat.c
--- rs6000-nat.c	7 Aug 2013 14:39:57 -0000	1.129
+++ rs6000-nat.c	23 Aug 2013 06:46:18 -0000
@@ -131,11 +131,11 @@ regmap (struct gdbarch *gdbarch, int reg
 static int
 rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf)
 {
-  #ifdef HAVE_PTRACE64
+#ifdef HAVE_PTRACE64
   int ret = ptrace64 (req, id, (long long) addr, data, buf);
-  #else
+#else
   int ret = ptrace (req, id, (int *)addr, data, buf);
-  #endif
+#endif
 #if 0
   printf ("rs6000_ptrace32 (%d, %d, 0x%x, %08x, 0x%x) = 0x%x\n",
 	  req, id, (unsigned int)addr, data, (unsigned int)buf, ret);
@@ -149,11 +149,11 @@ static int
 rs6000_ptrace64 (int req, int id, long long addr, int data, void *buf)
 {
 #ifdef ARCH3264
-  #ifdef HAVE_PTRACE64
+#  ifdef HAVE_PTRACE64
   int ret = ptrace64 (req, id, addr, data, buf);
-  #else
+#  else
   int ret = ptracex (req, id, addr, data, buf);
-  #endif
+#  endif
 #else
   int ret = 0;
 #endif


      parent reply	other threads:[~2013-08-23  6:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-18  1:51 GDB Administrator
2013-08-18 11:14 ` Pierre Muller
2013-08-19 18:18   ` Joel Brobecker
2013-08-23  6:55   ` Pierre Muller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001201ce9fcd$a31b7200$e9525600$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox