[RFA] ARI fix: linux-nat.c: remove strlen d_name

[RFA] ARI fix: linux-nat.c: remove strlen d_name

[Pierre Muller]

  Here also, I could have used the obvious rule,
but I am still not really sure about the
ChangeLog entry.
  I was unable to find the proper way to tag
a ChangeLog entry for Awk Regression Index.

  Does anyone remember?

  Is this OK to commit?

Pierre Muller
Pascal language support maintainer for GDB


ChangeLog entry:


2009-03-24  Pierre Muller  <muller@ics.u-strasbg.fr>

	ARI fix: "strlen d_name" rule.
	* linux-nat.c (linux_nat_xfer_osdata): Use NAMELEN macro.


$ cvs diff -up linux-nat.c
Index: linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-nat.c,v
retrieving revision 1.125
diff -u -p -r1.125 linux-nat.c
--- linux-nat.c 18 Mar 2009 16:47:45 -0000      1.125
+++ linux-nat.c 23 Mar 2009 23:44:14 -0000
@@ -4163,7 +4163,7 @@ linux_nat_xfer_osdata (struct target_ops
              char procentry[sizeof ("/proc/4294967295")];

              if (!isdigit (dp->d_name[0])
-                 || strlen (dp->d_name) > sizeof ("4294967295") - 1)
+                 || NAMELEN (dp) > sizeof ("4294967295") - 1)
                continue;

              sprintf (procentry, "/proc/%s", dp->d_name);

Re: [RFA] ARI fix: linux-nat.c: remove strlen d_name

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre>   I was unable to find the proper way to tag
Pierre> a ChangeLog entry for Awk Regression Index.
Pierre>   Does anyone remember?

Is there a particular need to have a defined format for this?
Anything clear seems reasonable to me.

Pierre>   Is this OK to commit?

Yes, thanks.

Tom

RE: [RFA] ARI fix: linux-nat.c: remove strlen d_name

[Pierre Muller]

Thanks, committed.

Pierre

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Wednesday, March 25, 2009 1:10 AM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] ARI fix: linux-nat.c: remove strlen d_name
> 
> >>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
> 
> Pierre>   I was unable to find the proper way to tag
> Pierre> a ChangeLog entry for Awk Regression Index.
> Pierre>   Does anyone remember?
> 
> Is there a particular need to have a defined format for this?
> Anything clear seems reasonable to me.
> 
> Pierre>   Is this OK to commit?
> 
> Yes, thanks.
> 
> Tom