From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18758 invoked by alias); 24 Mar 2009 00:00:52 -0000 Received: (qmail 18703 invoked by uid 22791); 24 Mar 2009 00:00:50 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Mar 2009 00:00:45 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n2O00ftf025341 for ; Tue, 24 Mar 2009 01:00:41 +0100 (CET) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n2O00ekE095774 for ; Tue, 24 Mar 2009 01:00:41 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n2O00eVA091563 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Tue, 24 Mar 2009 01:00:40 +0100 (CET) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Subject: [RFA] ARI fix: linux-nat.c: remove strlen d_name Date: Tue, 24 Mar 2009 00:23:00 -0000 Message-ID: <000a01c9ac13$96f4c6f0$c4de54d0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00513.txt.bz2 Here also, I could have used the obvious rule, but I am still not really sure about the ChangeLog entry. I was unable to find the proper way to tag a ChangeLog entry for Awk Regression Index. Does anyone remember? Is this OK to commit? Pierre Muller Pascal language support maintainer for GDB ChangeLog entry: 2009-03-24 Pierre Muller ARI fix: "strlen d_name" rule. * linux-nat.c (linux_nat_xfer_osdata): Use NAMELEN macro. $ cvs diff -up linux-nat.c Index: linux-nat.c =================================================================== RCS file: /cvs/src/src/gdb/linux-nat.c,v retrieving revision 1.125 diff -u -p -r1.125 linux-nat.c --- linux-nat.c 18 Mar 2009 16:47:45 -0000 1.125 +++ linux-nat.c 23 Mar 2009 23:44:14 -0000 @@ -4163,7 +4163,7 @@ linux_nat_xfer_osdata (struct target_ops char procentry[sizeof ("/proc/4294967295")]; if (!isdigit (dp->d_name[0]) - || strlen (dp->d_name) > sizeof ("4294967295") - 1) + || NAMELEN (dp) > sizeof ("4294967295") - 1) continue; sprintf (procentry, "/proc/%s", dp->d_name);