Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] ARI fix: linux-nat.c: remove strlen d_name
Date: Tue, 24 Mar 2009 00:23:00 -0000	[thread overview]
Message-ID: <000a01c9ac13$96f4c6f0$c4de54d0$@u-strasbg.fr> (raw)

  Here also, I could have used the obvious rule,
but I am still not really sure about the
ChangeLog entry.
  I was unable to find the proper way to tag
a ChangeLog entry for Awk Regression Index.

  Does anyone remember?

  Is this OK to commit?

Pierre Muller
Pascal language support maintainer for GDB


ChangeLog entry:


2009-03-24  Pierre Muller  <muller@ics.u-strasbg.fr>

	ARI fix: "strlen d_name" rule.
	* linux-nat.c (linux_nat_xfer_osdata): Use NAMELEN macro.


$ cvs diff -up linux-nat.c
Index: linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-nat.c,v
retrieving revision 1.125
diff -u -p -r1.125 linux-nat.c
--- linux-nat.c 18 Mar 2009 16:47:45 -0000      1.125
+++ linux-nat.c 23 Mar 2009 23:44:14 -0000
@@ -4163,7 +4163,7 @@ linux_nat_xfer_osdata (struct target_ops
              char procentry[sizeof ("/proc/4294967295")];

              if (!isdigit (dp->d_name[0])
-                 || strlen (dp->d_name) > sizeof ("4294967295") - 1)
+                 || NAMELEN (dp) > sizeof ("4294967295") - 1)
                continue;

              sprintf (procentry, "/proc/%s", dp->d_name);


             reply	other threads:[~2009-03-24  0:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24  0:23 Pierre Muller [this message]
2009-03-25  0:31 ` Tom Tromey
2009-03-25 11:01   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01c9ac13$96f4c6f0$c4de54d0$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox